Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_rviz_planning_plugin): clear objects before return #2995

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Mar 3, 2023

Description

Fix a problem that the old visualized path remains in Rviz.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ce056f) 11.99% compared to head (ab83728) 11.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   11.99%   11.99%           
=======================================
  Files        1315     1315           
  Lines       91487    91487           
  Branches    24259    24259           
=======================================
  Hits        10971    10971           
  Misses      69155    69155           
  Partials    11361    11361           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.99% <ø> (+<0.01%) ⬆️ Carriedforward from 1afeb8b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_planning_rviz_plugin/include/path/display.hpp 0.00% <0.00%> (ø)
...planning_rviz_plugin/include/path/display_base.hpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 enabled auto-merge (squash) March 3, 2023 06:11
@purewater0901 purewater0901 merged commit 36fcf3f into main Mar 3, 2023
@purewater0901 purewater0901 deleted the fix/clear-object branch March 3, 2023 07:05
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…efoundation#2995)

* fix(tier4_rviz_planning_plugin): clear objects before return

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants