Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne_monitor): add fmt package to dependencies #3069

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix(velodyne_monitor): add fmt package to dependencies #3069

merged 3 commits into from
Mar 14, 2023

Conversation

drwnz
Copy link
Contributor

@drwnz drwnz commented Mar 14, 2023

Description

Before

When building using --packages-up-to, the build fails with missing dependencies.

After

Build passes.

Environment: This issue occurred when building the TLR software stack and dependent packages (--packages-up-to jetson_tlr_launch in Humble).

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@drwnz drwnz requested review from aohsato and manato March 14, 2023 01:27
@drwnz drwnz requested review from ito-san and a team as code owners March 14, 2023 01:27
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.99 🎉

Comparison is base (be0929b) 11.86% compared to head (d001ee2) 12.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3069      +/-   ##
==========================================
+ Coverage   11.86%   12.85%   +0.99%     
==========================================
  Files        1333     1213     -120     
  Lines       92801    85015    -7786     
  Branches    24660    23936     -724     
==========================================
- Hits        11014    10932      -82     
+ Misses      70372    62749    -7623     
+ Partials    11415    11334      -81     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 12.85% <ø> (+0.99%) ⬆️ Carriedforward from 2f171c5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/include/behavior_path_planner/utilities.hpp 23.80% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <ø> (ø)
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <ø> (ø)
planning/behavior_path_planner/src/utilities.cpp 8.20% <ø> (+0.62%) ⬆️

... and 192 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san enabled auto-merge (squash) March 14, 2023 01:40
@ito-san ito-san merged commit 87e4422 into autowarefoundation:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants