Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): fix build error #3100

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 17, 2023

Description

Since [[maybe_unused]] was removed in #3083, build error are shown when it sets following flag to FALSE.

set(COMPILE_WITH_OLD_ARCHITECTURE TRUE)

--- stderr: behavior_path_planner                                                                                                                                                                            
/home/satoshi/pilot-auto/src/autoware/universe/planning/behavior_path_planner/src/util/lane_change/util.cpp: In function 'std::pair<bool, bool> behavior_path_planner::lane_change_utils::getLaneChangePaths(const PathWithLaneId&, const route_handler::RouteHandler&, const ConstLanelets&, const ConstLanelets&, const Pose&, const Twist&, autoware_auto_perception_msgs::msg::PredictedObjects_<std::allocator<void> >::Con
stSharedPtr, const BehaviorPathPlannerParameters&, const behavior_path_planner::LaneChangeParameters&, double, behavior_path_planner::LaneChangePaths*, std::unordered_map<std::__cxx11::basic_string<char>, marker_utils::CollisionCheckDebug>*)':
/home/satoshi/pilot-auto/src/autoware/universe/planning/behavior_path_planner/src/util/lane_change/util.cpp:318:14: error: variable 'arc_position_from_current' set but not used [-Werror=unused-but-set-variable]
  318 |   const auto arc_position_from_current = lanelet::utils::getArcCoordinates(original_lanelets, pose);  

Related PR: #3083

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 17, 2023
@satoshi-ota satoshi-ota enabled auto-merge (squash) March 17, 2023 00:59
@satoshi-ota
Copy link
Contributor Author

@shmpwk Thanks 👍

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a23a4b) 11.92% compared to head (41901b8) 11.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3100   +/-   ##
=======================================
  Coverage   11.92%   11.92%           
=======================================
  Files        1334     1334           
  Lines       92928    92928           
  Branches    24729    24729           
=======================================
  Hits        11078    11078           
  Misses      70370    70370           
  Partials    11480    11480           
Flag Coverage Δ *Carryforward flag
differential 5.55% <0.00%> (?)
total 11.92% <ø> (+<0.01%) ⬆️ Carriedforward from 2a23a4b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ehavior_path_planner/src/util/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit b2524e4 into autowarefoundation:main Mar 17, 2023
@satoshi-ota satoshi-ota deleted the fix/build-error-lane-change branch March 17, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants