Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system_error_monitor): fix dying node #3103

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 17, 2023

Description

Currently, system_error_monitor died with the following error due to the time resource is different.
what(): can't subtract times with different time sources [1 != 2]

related discussion: https://answers.ros.org/question/380328/robot_localization-cant-subtract-times-with-different-time-sources/

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Mar 17, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review March 17, 2023 04:12
@takayuki5168 takayuki5168 requested review from ito-san, kenji-miyake and a team as code owners March 17, 2023 04:12
@takayuki5168
Copy link
Contributor Author

I confirmed that system_error_monitor does not die with this PR on the planning simulator.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (f210e40) 11.92% compared to head (89504cf) 11.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   11.92%   11.92%   -0.01%     
==========================================
  Files        1332     1332              
  Lines       92934    92937       +3     
  Branches    24735    24735              
==========================================
  Hits        11079    11079              
- Misses      70376    70379       +3     
  Partials    11479    11479              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.92% <ø> (ø) Carriedforward from f210e40

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...em_error_monitor/src/system_error_monitor_core.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ito-san ito-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this issue was gone by this fix.

@takayuki5168 takayuki5168 merged commit dd5c6ea into autowarefoundation:main Mar 17, 2023
@takayuki5168 takayuki5168 deleted the fix/system-error-monitor-die branch March 17, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants