-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission_planner): add the interface to reroute while driving #3184
Closed
isamu-takagi
wants to merge
7
commits into
autowarefoundation:main
from
isamu-takagi:feat/driving-route-change
Closed
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
154fe9a
feat: add change route service
isamu-takagi 1543f5b
Merge branch 'main' into feat/driving-route-change
isamu-takagi e3edaca
feat: add internal interface
isamu-takagi 41148cc
feat: use service to set mrm goal
isamu-takagi 8987a54
feat: rename goal
isamu-takagi 2ebc073
feat: change topic name prefix
isamu-takagi 3a1a446
feat: update readme
isamu-takagi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
planning/mission_planner/include/mission_planner/mission_planner_interface.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
// Copyright 2023 TIER IV, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#ifndef MISSION_PLANNER__MISSION_PLANNER_INTERFACE_HPP_ | ||
#define MISSION_PLANNER__MISSION_PLANNER_INTERFACE_HPP_ | ||
|
||
#include <rclcpp/qos.hpp> | ||
|
||
#include <autoware_planning_msgs/msg/pose_with_uuid_stamped.hpp> | ||
#include <std_srvs/srv/trigger.hpp> | ||
|
||
namespace mission_planner | ||
{ | ||
|
||
struct NewGoal | ||
{ | ||
using Message = autoware_planning_msgs::msg::PoseWithUuidStamped; | ||
static constexpr char name[] = "~/sub/new_goal"; | ||
static constexpr size_t depth = 1; | ||
static constexpr auto reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE; | ||
static constexpr auto durability = RMW_QOS_POLICY_DURABILITY_VOLATILE; | ||
}; | ||
|
||
struct MrmGoal | ||
{ | ||
using Message = autoware_planning_msgs::msg::PoseWithUuidStamped; | ||
static constexpr char name[] = "~/sub/mrm_goal"; | ||
static constexpr size_t depth = 1; | ||
static constexpr auto reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE; | ||
static constexpr auto durability = RMW_QOS_POLICY_DURABILITY_VOLATILE; | ||
}; | ||
|
||
struct ClearMrm | ||
{ | ||
using Service = std_srvs::srv::Trigger; | ||
static constexpr char name[] = "~/srv/clear_mrm"; | ||
}; | ||
|
||
} // namespace mission_planner | ||
|
||
#endif // MISSION_PLANNER__MISSION_PLANNER_INTERFACE_HPP_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isamu-takagi cc @mitsudome-r @yukkysaito
Could you please clarify why we need the
change
APIs in addition to the existingset
APIs? If it's already documented, just writing the link is fine!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was created for MRM pull over (#3221). Since the route change by MRM pull over is done while driving, it is necessary to keep the route for some distance. The
change route
interface diverts this so that it can be used in normal operations as well. Therefore, the interface is separated to call a different process than theset route
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I understand.
But I feel it's a little different from what I guess from the word
reroute
.Also, I think it can be completed within the Planning component, so I'm not sure whether we need to add new component interfaces for this.
I'll wait for comments from other architects.
(I forgot to mention @xmfcx, sorry.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenji-miyake I made a block diagram. This is the interface between ADAPI and planning.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isamu-takagi Thank you, but when and why do users call this
change
API? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenji-miyake For example, when users want to change the goal while driving, or when splitting a route to create a circular route.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm sorry I don't understand the use cases well... 🥺
I'll leave the review to @mitsudome-r and @yukkysaito.