Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): add route change api #3197

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Mar 28, 2023

Description

Add route change (reroute) API. See autowarefoundation/autoware#3406 for details.

Related links

autowarefoundation/autoware#3406
#3461

Tests performed

  • Check autonomous driving in simple planning simulator.
  • Check reroute while driving in simple planning simulator.

Notes for reviewers

Assigning the 2D Rough Goal Pose tool to reroute makes testing easier.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Mar 28, 2023
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Mar 28, 2023
@isamu-takagi isamu-takagi force-pushed the feat/adapi-change-route branch from 223301d to b530a39 Compare April 20, 2023 07:14
@isamu-takagi isamu-takagi marked this pull request as ready for review April 20, 2023 07:18
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.82 ⚠️

Comparison is base (1d4bf8e) 14.67% compared to head (7a36628) 13.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3197      +/-   ##
==========================================
- Coverage   14.67%   13.85%   -0.82%     
==========================================
  Files        1292     1391      +99     
  Lines       91647    97032    +5385     
  Branches    28835    28589     -246     
==========================================
- Hits        13451    13446       -5     
- Misses      63752    69168    +5416     
+ Partials    14444    14418      -26     
Flag Coverage Δ *Carryforward flag
differential 14.59% <0.00%> (?)
total 13.85% <ø> (-0.82%) ⬇️ Carriedforward from ae820da

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <ø> (ø)
...nner/include/scene_module/intersection/manager.hpp 0.00% <ø> (ø)
...er/include/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <ø> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <ø> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <ø> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <ø> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <ø> (ø)
...de_manager/src/rtc_auto_mode_manager_interface.cpp 0.00% <ø> (ø)
planning/rtc_interface/src/rtc_interface.cpp 20.45% <ø> (ø)
... and 2 more

... and 142 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi enabled auto-merge (squash) April 24, 2023 05:07
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit cc55996 into autowarefoundation:main Apr 24, 2023
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
* feat: add route change api

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix: reroute

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants