-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(default_ad_api): add route change api #3197
feat(default_ad_api): add route change api #3197
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
223301d
to
b530a39
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
==========================================
- Coverage 14.67% 13.85% -0.82%
==========================================
Files 1292 1391 +99
Lines 91647 97032 +5385
Branches 28835 28589 -246
==========================================
- Hits 13451 13446 -5
- Misses 63752 69168 +5416
+ Partials 14444 14418 -26
*This pull request uses carry forward flags. Click here to find out more.
... and 142 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: add route change api Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix: reroute Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Add route change (reroute) API. See autowarefoundation/autoware#3406 for details.
Related links
autowarefoundation/autoware#3406
#3461
Tests performed
Notes for reviewers
Assigning the
2D Rough Goal Pose
tool to reroute makes testing easier.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.