-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): make drivable area expansion parameters common #3499
feat(behavior_path_planner): make drivable area expansion parameters common #3499
Conversation
bfc25d5
to
165d925
Compare
…common Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
165d925
to
4a06c5c
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3499 +/- ##
=======================================
Coverage 13.80% 13.81%
=======================================
Files 1391 1392 +1
Lines 97408 97393 -15
Branches 28829 28802 -27
=======================================
+ Hits 13450 13457 +7
+ Misses 69501 69497 -4
+ Partials 14457 14439 -18
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in the planning simulator and the drivable area expansion works well.
@satoshi-ota Could you just approve the PR. |
…common (autowarefoundation#3499) * feat(behavior_path_planner): make drivable area expansion parameters common Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Nonoverlap -> NonOverlap Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Currently, we have different drivable area expansion parameters for each module (lane change, avoidance, ...).
However, since with a new behavior_path_planner architecture, multiple modules are launched simultaneously, it's hard to expand the drivable area with different module's expansion parameters when multiple modules are launched.
Therefore, I changed the logic to have ONE set of parameters for all modules so that drivable area expansion future works well when multiple modules are launched.
Tests performed
planning simulator worked well.
Effects on system behavior
Nothing. (With this PR, we cannot expand the drivable area statically with each module's different parameters)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.