Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): make drivable area expansion parameters common #3499

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 22, 2023

Description

Currently, we have different drivable area expansion parameters for each module (lane change, avoidance, ...).

However, since with a new behavior_path_planner architecture, multiple modules are launched simultaneously, it's hard to expand the drivable area with different module's expansion parameters when multiple modules are launched.

Therefore, I changed the logic to have ONE set of parameters for all modules so that drivable area expansion future works well when multiple modules are launched.

Tests performed

planning simulator worked well.

Effects on system behavior

Nothing. (With this PR, we cannot expand the drivable area statically with each module's different parameters)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 22, 2023
@takayuki5168 takayuki5168 force-pushed the feat/common-dynamic-drivable-area-width branch from bfc25d5 to 165d925 Compare April 22, 2023 13:56
…common

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/common-dynamic-drivable-area-width branch from 165d925 to 4a06c5c Compare April 22, 2023 13:57
@takayuki5168 takayuki5168 changed the title make drivable area expansion parameters common feat(behavior_path_planner): make drivable area expansion parameters common Apr 22, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 1.72% and no project coverage change.

Comparison is base (50292eb) 13.80% compared to head (8082a9d) 13.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3499   +/-   ##
=======================================
  Coverage   13.80%   13.81%           
=======================================
  Files        1391     1392    +1     
  Lines       97408    97393   -15     
  Branches    28829    28802   -27     
=======================================
+ Hits        13450    13457    +7     
+ Misses      69501    69497    -4     
+ Partials    14457    14439   -18     
Flag Coverage Δ *Carryforward flag
differential 12.66% <1.72%> (?)
total 13.81% <ø> (+<0.01%) ⬆️ Carriedforward from 50292eb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...anner/include/behavior_path_planner/parameters.hpp 0.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 37.00% <0.00%> (-2.37%) ⬇️
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...anner/utils/drivable_area_expansion/parameters.hpp 20.00% <0.00%> (-3.34%) ⬇️
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...ath_planner/utils/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...planner/utils/side_shift/side_shift_parameters.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 20.20% <0.00%> (+1.36%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 3.43% <ø> (+<0.01%) ⬆️
...lanner/src/scene_module/avoidance_by_lc/module.cpp 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Apr 23, 2023

Working good (offset is 1.0 [m])
image

Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the planning simulator and the drivable area expansion works well.

@takayuki5168
Copy link
Contributor Author

@satoshi-ota Could you just approve the PR.

@takayuki5168 takayuki5168 merged commit 1d4bf8e into autowarefoundation:main Apr 24, 2023
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…common (autowarefoundation#3499)

* feat(behavior_path_planner): make drivable area expansion parameters common

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* Nonoverlap -> NonOverlap

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
@rej55 rej55 deleted the feat/common-dynamic-drivable-area-width branch December 25, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants