-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(intersection): fix virtual wall pose #3529
fix(intersection): fix virtual wall pose #3529
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right thank you!
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3529 +/- ##
=======================================
Coverage 14.05% 14.05%
=======================================
Files 1397 1397
Lines 98030 98030
Branches 29104 29104
=======================================
Hits 13779 13779
Misses 69588 69588
Partials 14663 14663
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…op line when occlusion is detected (#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge #3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
…op line when occlusion is detected (autowarefoundation#3528) * a bit refactored Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting at the first stop line when isVehicleStopped() Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * start waiting when vehicle is stopped when near the stop line Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * merge autowarefoundation#3529 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
Without this PR, the virtual wall pose is an offset ahead from the actual wall pose.
Tests performed
planning simulator works well
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.