Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): fix virtual wall pose #3529

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Apr 25, 2023

Description

Without this PR, the virtual wall pose is an offset ahead from the actual wall pose.

Tests performed

planning simulator works well

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 25, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review April 25, 2023 07:59
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right thank you!

@soblin soblin enabled auto-merge (squash) April 25, 2023 08:08
soblin added a commit to soblin/autoware.universe that referenced this pull request Apr 25, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (001a865) 14.05% compared to head (a85746a) 14.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3529   +/-   ##
=======================================
  Coverage   14.05%   14.05%           
=======================================
  Files        1397     1397           
  Lines       98030    98030           
  Branches    29104    29104           
=======================================
  Hits        13779    13779           
  Misses      69588    69588           
  Partials    14663    14663           
Flag Coverage Δ *Carryforward flag
differential 3.45% <0.00%> (?)
total 14.05% <ø> (+<0.01%) ⬆️ Carriedforward from 001a865

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 8d0479f into autowarefoundation:main Apr 25, 2023
@soblin soblin deleted the fix/intersection-ego-ahead-pose branch April 25, 2023 09:03
soblin added a commit that referenced this pull request Apr 25, 2023
…op line when occlusion is detected (#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge #3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request May 1, 2023
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to soblin/autoware.universe that referenced this pull request May 7, 2023
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…op line when occlusion is detected (autowarefoundation#3528)

* a bit refactored

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting at the first stop line when isVehicleStopped()

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* start waiting when vehicle is stopped when near the stop line

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* merge autowarefoundation#3529

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants