-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vehicle_cmd_gate): rename adapi pause interface #3794
refactor(vehicle_cmd_gate): rename adapi pause interface #3794
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3794 +/- ##
==========================================
- Coverage 14.44% 14.03% -0.42%
==========================================
Files 1456 1440 -16
Lines 102483 99791 -2692
Branches 29691 26333 -3358
==========================================
- Hits 14806 14006 -800
+ Misses 71523 70455 -1068
+ Partials 16154 15330 -824
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@TakaHoribe @tkimura4 I have resolved the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Since the pause interface has specialized processing for AD API and its name is confusing, I changed its name and added a comment.
Tests performed
Check autonomous mode driving in simple planning simulator.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.