Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): not rest modules when new route with same uuid is recived #3961

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 13, 2023

Description

fix goal_planner activation chattering.
the route uuid is same when rerouting with modified_goal, in that case, we do not need to reset modules.

Related links

Tests performed

psim

Notes for reviewers

Interface changes

not applicable

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

… uuid is recived

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.05 🎉

Comparison is base (07f8de7) 14.45% compared to head (c99997b) 14.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3961      +/-   ##
==========================================
+ Coverage   14.45%   14.50%   +0.05%     
==========================================
  Files        1456     1456              
  Lines      102537   103259     +722     
  Branches    29652    30204     +552     
==========================================
+ Hits        14819    14981     +162     
- Misses      71567    71948     +381     
- Partials    16151    16330     +179     
Flag Coverage Δ *Carryforward flag
differential 12.85% <33.33%> (?)
total 14.45% <ø> (-0.01%) ⬇️ Carriedforward from 07f8de7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 22.23% <33.33%> (+3.58%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 6a86265 into autowarefoundation:main Jun 13, 2023
@kosuke55 kosuke55 deleted the fix/not_clear_when_same_uuid branch June 13, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants