fix(goal_planenr): not reset when receving new route #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
github-actions
bot
added
the
component:planning
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55
force-pushed
the
fix/not_reset_goal_planner
branch
from
e99095e to
2df572e
Compare
purewater0901
approved these changes
Jun 13, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
==========================================
- Coverage 14.42% 14.42% -0.01%
==========================================
Files 1456 1456
Lines 102581 102582 +1
Branches 29674 29675 +1
==========================================
- Hits 14797 14796 -1
Misses 71645 71645
- Partials 16139 16141 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2023
…ion#3966) * fix(goal_planenr): not reset when receving new route Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix for old archi Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix reset goal planner twice.
currently when receiving new route reset scene modules in https://github.com/autowarefoundation/autoware.universe/blob/fix/not_reset_goal_planner/planning/behavior_path_planner/src/behavior_path_planner_node.cpp#L1232
so, no need to reset in goal_planner
note that, in old architecture still reset twice.
Related links
Tests performed
psim
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.