-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix opencv dependency #3987
Conversation
f62a185
to
926a235
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3987 +/- ##
==========================================
+ Coverage 14.37% 15.31% +0.93%
==========================================
Files 1563 1457 -106
Lines 107585 100989 -6596
Branches 31150 31154 +4
==========================================
Hits 15465 15465
+ Misses 75315 68720 -6595
+ Partials 16805 16804 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
926a235
to
8db1fba
Compare
@mitsudome-r @xmfcx this change fixes the Debian builds for |
@xmfcx thanks for the quick review |
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
8db1fba
to
e1abd2b
Compare
@xmfcx I've enabled auto-merge for this PR, I don't know why it hasn't merged itself after you approved it. Do you know why? |
I needed to add myself to global code owners team and re-approve, merge, remove myself from the team. |
Description
This PR adds
opencv-dev
as a depdency inpackage.xml
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.