Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix opencv dependency #3987

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jun 15, 2023

Description

This PR adds opencv-dev as a depdency in package.xml

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 38.46% and project coverage change: +0.93 🎉

Comparison is base (4ee6975) 14.37% compared to head (e1abd2b) 15.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3987      +/-   ##
==========================================
+ Coverage   14.37%   15.31%   +0.93%     
==========================================
  Files        1563     1457     -106     
  Lines      107585   100989    -6596     
  Branches    31150    31154       +4     
==========================================
  Hits        15465    15465              
+ Misses      75315    68720    -6595     
+ Partials    16805    16804       -1     
Flag Coverage Δ *Carryforward flag
differential 13.55% <38.46%> (?)
total 15.31% <ø> (+0.93%) ⬆️ Carriedforward from 4ee6975

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...cene_module/start_planner/start_planner_module.hpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 11.68% <ø> (+0.01%) ⬆️
...cene_module/start_planner/start_planner_module.cpp 4.03% <0.00%> (-0.04%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 61.53% <33.33%> (-25.97%) ⬇️
...er/scene_module/scene_module_manager_interface.hpp 26.00% <100.00%> (ø)

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@esteve esteve force-pushed the fix-opencv-dependency branch from 926a235 to 8db1fba Compare June 23, 2023 10:52
@esteve
Copy link
Contributor Author

esteve commented Jun 23, 2023

@mitsudome-r @xmfcx this change fixes the Debian builds for behavior_path_planner, it'd nice to get it merged before the 2023.07 release.

@esteve
Copy link
Contributor Author

esteve commented Jun 23, 2023

@xmfcx thanks for the quick review

@esteve esteve enabled auto-merge (squash) June 23, 2023 11:31
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the fix-opencv-dependency branch from 8db1fba to e1abd2b Compare June 23, 2023 13:42
@esteve
Copy link
Contributor Author

esteve commented Jun 23, 2023

@xmfcx I've enabled auto-merge for this PR, I don't know why it hasn't merged itself after you approved it. Do you know why?

@esteve esteve merged commit 6c6973b into autowarefoundation:main Jun 23, 2023
@xmfcx
Copy link
Contributor

xmfcx commented Jun 23, 2023

I needed to add myself to global code owners team and re-approve, merge, remove myself from the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants