Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_traffic_light_module): print not found traffic ids for warning #4045

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 22, 2023

Description

Add traffic light ids information in the warning of not found traffic light.

[component_container_mt-27] [WARN 1687442666.245190345] [planning.scenario_planning.lane_driving.behavior_planning.behavior_velocity_planner.traffic_light_module]: cannot find traffic light lamp state (391,393,395,397,399) due to TrafficSignalNotFound. (getHighestConfidenceTrafficSignal():451)

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… ids for warning

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 22, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review June 22, 2023 14:10
@takayuki5168 takayuki5168 requested review from satoshi-ota, shmpwk, tkimura4 and a team as code owners June 22, 2023 14:10
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3b162aa) 14.31% compared to head (62c6378) 14.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4045      +/-   ##
==========================================
- Coverage   14.31%   14.31%   -0.01%     
==========================================
  Files        1557     1557              
  Lines      106900   106904       +4     
  Branches    30777    30781       +4     
==========================================
  Hits        15301    15301              
- Misses      75028    75032       +4     
  Partials    16571    16571              
Flag Coverage Δ *Carryforward flag
differential 17.69% <0.00%> (?)
total 14.31% <ø> (ø) Carriedforward from 3b162aa

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_velocity_traffic_light_module/src/scene.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 385ef5b into autowarefoundation:main Jun 23, 2023
@takayuki5168 takayuki5168 deleted the feat/traffic-light-warn-additional-information branch June 23, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants