fix(image_projection_based_fusion): fix out-of-scope error

[yukke42]

Description

fix a bug by the update of sync alrogithm of this package

Related links

Tests performed

I have checked with some rosbag that there are no errors.

blue bounding boxes are output objects.
yellow bounding boxes are filtered out objects.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Summary by CodeRabbit

Release Notes:

• Refactor: The RoiDetectedObjectFusionNode class in the node.hpp file has been modified. The generateDetectedObjectRoIs and fuseObjectsOnImage functions now accept a DetectedObjects message as input instead of a vector of DetectedObject objects. The member variables passthrough_object_flags_, fused_object_flags_, and ignored_object_flags_ have been changed to maps (passthrough_object_flags_map_, fused_object_flags_map_, and ignored_object_flags_map_) with int64_t keys.

"Code transformed, objects fused,
With maps and messages, it's infused.
Bugs evicted, logic refined,
A celebration of code, we find."

[github-actions]

CodeRabbit

Walkthrough

The changes include modifications to the RoiDetectedObjectFusionNode class in the node.hpp file. The generateDetectedObjectRoIs and fuseObjectsOnImage functions now accept a DetectedObjects message as input instead of a vector of DetectedObject objects. Additionally, the member variables passthrough_object_flags_, fused_object_flags_, and ignored_object_flags_ have been changed to maps (passthrough_object_flags_map_, fused_object_flags_map_, and ignored_object_flags_map_) with int64_t keys.

Changes

File	Summary
perception/image_projection_based_fusion/include/image_projection_based_fusion/roi_detected_object_fusion/node.hpp	Modifications to the RoiDetectedObjectFusionNode class: generateDetectedObjectRoIs and fuseObjectsOnImage now accept DetectedObjects message as input. Member variables passthrough_object_flags_, fused_object_flags_, and ignored_object_flags_ changed to maps with int64_t keys.

[github-actions]

CodeRabbit

Commits

Files that changed from the base of the PR and between 404a3b1 and 9af08d5 commits.

Files selected (2)

• perception/image_projection_based_fusion/include/image_projection_based_fusion/roi_detected_object_fusion/node.hpp (2)
• perception/image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp (9)

Files not summarized due to errors (1)

• perception/image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp (diff tokens exceeds limit)

Review comments generated (6)

• Review: 3
• LGTM: 3

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
• Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

• The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
• You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

• Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

[codecov]

Codecov Report

Patch coverage: 7.54% and project coverage change: -0.51% ⚠️

Comparison is base (2e5752f) 14.80% compared to head (b3eb283) 14.30%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4057      +/-   ##
==========================================
- Coverage   14.80%   14.30%   -0.51%     
==========================================
  Files        1527     1557      +30     
  Lines      105643   106941    +1298     
  Branches    32096    30758    -1338     
==========================================
- Hits        15642    15293     -349     
- Misses      72925    75085    +2160     
+ Partials    17076    16563     -513     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	14.34% <28.57%> (-0.47%)	⬇️	Carriedforward from 9af08d5

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
...n_based_fusion/roi_detected_object_fusion/node.hpp	0.00% <ø> (ø)
...sed_fusion/src/roi_detected_object_fusion/node.cpp	0.00% <0.00%> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp	0.00% <ø> (-8.34%)	⬇️
..._planner/utils/avoidance/avoidance_module_data.hpp	0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp	4.13% <28.57%> (-7.90%)	⬇️

... and 436 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yukkysaito]

LGTM