Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): separate visualization after path approval #4107

Merged

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

Because lane change cancel is instantaneous, it is difficult to see which object that cause the lane change to get cancelled.

In this PR, the lane change cancelled information is hold for 2 second, and the information is separated from before approval debug information.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 7.40% and project coverage change: -0.01 ⚠️

Comparison is base (dc29d01) 15.19% compared to head (0c5edd7) 15.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
- Coverage   15.19%   15.19%   -0.01%     
==========================================
  Files        1491     1491              
  Lines      102790   102802      +12     
  Branches    31543    31553      +10     
==========================================
  Hits        15617    15617              
- Misses      70214    70225      +11     
- Partials    16959    16960       +1     
Flag Coverage Δ *Carryforward flag
differential 13.62% <7.40%> (?)
total 15.19% <ø> (+<0.01%) ⬆️ Carriedforward from dc29d01

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 15.90% <ø> (-0.37%) ⬇️
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.46% <0.00%> (-0.15%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.42% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.55% <9.30%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 881f734 into autowarefoundation:main Jul 18, 2023
purewater0901 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 19, 2023
…efoundation#4107)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lc-debug branch September 29, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants