Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix loop lanes #4304

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 18, 2023

Description

When route lane is looped can not generate path with start_planner.

utils::getExtendedCurrentLanes(
    planner_data_, backward_path_length, std::numeric_limits<double>::max());

In this PR, I added loop check to getExtendedCurrentLanes

Related links

Tests performed

psim

image

tier4 interanl sceanrio test

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 18, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 enabled auto-merge (squash) July 18, 2023 02:40
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 23.07% and project coverage change: -0.04 ⚠️

Comparison is base (dc29d01) 15.19% compared to head (4fcc825) 15.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4304      +/-   ##
==========================================
- Coverage   15.19%   15.16%   -0.04%     
==========================================
  Files        1491     1491              
  Lines      102790   103170     +380     
  Branches    31543    31793     +250     
==========================================
+ Hits        15617    15642      +25     
- Misses      70214    70535     +321     
- Partials    16959    16993      +34     
Flag Coverage Δ *Carryforward flag
differential 13.57% <23.07%> (?)
total 15.19% <ø> (+<0.01%) ⬆️ Carriedforward from dc29d01

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <ø> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.42% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.69% <12.50%> (+0.09%) ⬆️
planning/behavior_path_planner/src/utils/utils.cpp 16.69% <57.14%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit c23e7cd into main Jul 18, 2023
@kosuke55 kosuke55 deleted the fix/start_planner_loop_lane branch July 18, 2023 03:33
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jul 20, 2023
* fix(start_planner): fix loop lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add empty check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants