-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lane_change): use a single function for isEndOfLane #4338
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4338 +/- ##
==========================================
+ Coverage 15.06% 15.16% +0.09%
==========================================
Files 1508 1493 -15
Lines 103691 102915 -776
Branches 31653 31579 -74
==========================================
- Hits 15625 15610 -15
+ Misses 71059 70359 -700
+ Partials 17007 16946 -61
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This PR was blocked by failing CI which is caused by the issue with GitHub runner. I have merged this branch after checking the build locally. |
…efoundation#4338) * refactor(lane_change): use a single function for isEndOfLane Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> * add guard Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
Description
Currently, there are two similar functions to check whether the ego vehicle is near at the end of the lane. In this PR, I put them together and make a single function.
Tests performed
Scenario Test 1572/1588
TIER IV INTERNAL LINK
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.