Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): use a single function for isEndOfLane #4338

Merged
merged 8 commits into from
Jul 21, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 19, 2023

Description

Currently, there are two similar functions to check whether the ego vehicle is near at the end of the lane. In this PR, I put them together and make a single function.

Tests performed

Scenario Test 1572/1588
TIER IV INTERNAL LINK

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 19, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 4.51% and project coverage change: +0.09 🎉

Comparison is base (fc5ec80) 15.06% compared to head (9433add) 15.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4338      +/-   ##
==========================================
+ Coverage   15.06%   15.16%   +0.09%     
==========================================
  Files        1508     1493      -15     
  Lines      103691   102915     -776     
  Branches    31653    31579      -74     
==========================================
- Hits        15625    15610      -15     
+ Misses      71059    70359     -700     
+ Partials    17007    16946      -61     
Flag Coverage Δ *Carryforward flag
differential 13.51% <4.51%> (?)
total 15.18% <ø> (+0.11%) ⬆️ Carriedforward from 3a60d8f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/lane_change/base_class.hpp 15.90% <ø> (ø)
...r_path_planner/scene_module/lane_change/normal.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.38% <0.00%> (-0.09%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.55% <0.00%> (+<0.01%) ⬆️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.42% <0.00%> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 15.31% <2.58%> (-0.71%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 6.58% <37.50%> (+0.44%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.61% <50.00%> (+0.11%) ⬆️

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

purewater0901 and others added 4 commits July 20, 2023 11:26
@mitsudome-r mitsudome-r merged commit 9daf414 into main Jul 21, 2023
@mitsudome-r mitsudome-r deleted the refactor/clean-end-of-lane-function branch July 21, 2023 13:20
@mitsudome-r
Copy link
Member

This PR was blocked by failing CI which is caused by the issue with GitHub runner. I have merged this branch after checking the build locally.

kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
…efoundation#4338)

* refactor(lane_change): use a single function for isEndOfLane

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* add guard

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants