Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): remove unused local interpolate function #435

Merged
merged 4 commits into from
Feb 22, 2022
Merged

refactor(behavior_velocity_planner): remove unused local interpolate function #435

merged 4 commits into from
Feb 22, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Feb 22, 2022

Related Issue(required)

#430

Description(required)

  • The LinearInterpolate class has been removed from interpolate.cpp.
  • The rest of the functions have been moved to path_utilization.cpp and the interpolate.cpp/hpp files have been removed.

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #435 (9f35483) into tier4/proposal (9ce55c7) will decrease coverage by 4.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tier4/proposal    #435      +/-   ##
=================================================
- Coverage           10.20%   6.19%   -4.01%     
=================================================
  Files                 705      71     -634     
  Lines               49427    4873   -44554     
  Branches             6413     678    -5735     
=================================================
- Hits                 5043     302    -4741     
+ Misses              40213    4428   -35785     
+ Partials             4171     143    -4028     
Impacted Files Coverage Δ
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <ø> (ø)
...ule/intersection/scene_merge_from_private_road.cpp 0.00% <ø> (ø)
...ity_planner/src/scene_module/intersection/util.cpp 0.00% <0.00%> (ø)
...module/no_stopping_area/scene_no_stopping_area.cpp 0.00% <ø> (ø)
...ene_module/occlusion_spot/occlusion_spot_utils.cpp 11.11% <ø> (+2.02%) ⬆️
...sion_spot/scene_occlusion_spot_in_private_road.cpp 0.00% <0.00%> (ø)
...usion_spot/scene_occlusion_spot_in_public_road.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/utilization/path_utilization.cpp 0.00% <0.00%> (-26.67%) ⬇️
...ity_planner/test/src/test_occlusion_spot_utils.cpp 33.33% <ø> (-9.53%) ⬇️
... and 635 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2b646...9f35483. Read the comment docs.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 800c6c3 into autowarefoundation:tier4/proposal Feb 22, 2022
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
…function (autowarefoundation#435)

* move functions from interpolate.cpp to path_utilization.cpp

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove unused LinearInterpolate library

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix cpplint

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
…model (#435)

fix(planning_launch): modify delay_response_time for lexus model

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
… rtc_auto_mode_manager (autowarefoundation#435)

* add enable_rtc param

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* revert change of rviz config

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* revert change of rviz config
    
    Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
…commit-error-fix

refactor(cmd_helper): enclose the variable in double quotes (autowarefoundation#431)
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Aug 8, 2024
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants