Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): output drivable lanes marker #4373

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 23, 2023

Description

🤖 Generated by Copilot at 7654cbb

This pull request adds a new feature to the behavior path planner that allows it to represent and publish the drivable lanes in each scene module using marker arrays. The SceneModuleInterface and SceneModuleManagerInterface classes are modified to support this feature, and the AvoidanceModule class is updated to use it. This feature can improve the visualization and debugging of the behavior path planner.

image

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 23, 2023
@satoshi-ota satoshi-ota changed the title Feat/drivable lanes marker feat(behavior_path_planner): output drivable lanes marker Jul 23, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 9.09% and project coverage change: +0.03 🎉

Comparison is base (cbaaa69) 15.05% compared to head (7654cbb) 15.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4373      +/-   ##
==========================================
+ Coverage   15.05%   15.09%   +0.03%     
==========================================
  Files        1508     1508              
  Lines      103791   104869    +1078     
  Branches    31709    32527     +818     
==========================================
+ Hits        15629    15832     +203     
- Misses      71137    71854     +717     
- Partials    17025    17183     +158     
Flag Coverage Δ *Carryforward flag
differential 13.52% <9.09%> (?)
total 15.05% <ø> (ø) Carriedforward from cbaaa69

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/scene_module/scene_module_manager_interface.hpp 24.52% <0.00%> (-1.48%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 11.92% <0.00%> (-0.02%) ⬇️
...th_planner/scene_module/scene_module_interface.hpp 16.66% <25.00%> (+0.27%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit 68a702c into autowarefoundation:main Jul 25, 2023
@satoshi-ota satoshi-ota deleted the feat/drivable-lanes-marker branch July 25, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants