Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): suppress intersection occlusion chattering #4788

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 28, 2023

Description

Use a latched state machine to avoid chattering of intersection occlusion decision

Related links

TierIV COMPANY INTERNAL LINK
launcher PR: autowarefoundation/autoware_launch#533

Tests performed

Psim and experiment data

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 28, 2023
@soblin soblin force-pushed the feat/intersection/hold-int-occ-stop branch 2 times, most recently from e8a5b33 to 92eabce Compare August 30, 2023 05:20
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/hold-int-occ-stop branch from 92eabce to c16d9fb Compare August 30, 2023 05:22
@soblin soblin marked this pull request as ready for review August 30, 2023 05:24
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (33e2956) 15.09% compared to head (c16d9fb) 15.09%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4788      +/-   ##
==========================================
- Coverage   15.09%   15.09%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      108231   108247      +16     
  Branches    33231    33236       +5     
==========================================
  Hits        16342    16342              
- Misses      74070    74083      +13     
- Partials    17819    17822       +3     
Flag Coverage Δ *Carryforward flag
differential 7.00% <0.00%> (?)
total 15.09% <ø> (+<0.01%) ⬆️ Carriedforward from 33e2956

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...avior_velocity_intersection_module/src/manager.cpp 18.69% <0.00%> (-0.18%) ⬇️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 1afe476 into autowarefoundation:main Aug 30, 2023
@soblin soblin deleted the feat/intersection/hold-int-occ-stop branch August 30, 2023 06:38
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 30, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
soblin added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants