Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_path_planner): visualize debug information of safety check against dynamic obstacles #4892

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Sep 5, 2023

Description

added collision check marker in this PR

By utilizing this feature, visualize information in start/goal_planner.
And this PR contains minor refactor below

  • refactor debug implementation in avoidance module
  • commonize update module_date function
  • add comments

Screenshot from 2023-09-05 19-21-15
Screenshot from 2023-09-05 19-20-57

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Sep 5, 2023
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/visualize_safety_checker_information branch from abc9822 to 5f43c9b Compare September 5, 2023 11:19
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Sep 5, 2023
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 5, 2023
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review September 5, 2023 11:32
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…oal_planner_module.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 25.64% and project coverage change: -0.05% ⚠️

Comparison is base (2e6bc3f) 15.92% compared to head (b346f5d) 15.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4892      +/-   ##
==========================================
- Coverage   15.92%   15.88%   -0.05%     
==========================================
  Files        1579     1578       -1     
  Lines      108886   108869      -17     
  Branches    33584    33585       +1     
==========================================
- Hits        17344    17289      -55     
- Misses      72944    72994      +50     
+ Partials    18598    18586      -12     
Flag Coverage Δ *Carryforward flag
differential 18.47% <25.64%> (?)
total 15.86% <ø> (-0.07%) ⬇️ Carriedforward from 0ab6a3b

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 11.43% <0.00%> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 7.85% <0.00%> (-0.07%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 36.20% <18.18%> (-1.08%) ⬇️
...nner/src/utils/start_goal_planner_common/utils.cpp 40.35% <100.00%> (+7.01%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit a0b0227 into autowarefoundation:main Sep 7, 2023
kyoichi-sugahara added a commit to tier4/autoware.universe that referenced this pull request Sep 18, 2023
…y check against dynamic obstacles (autowarefoundation#4892)

* visualize debug info for safety check

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 24, 2023
…y check against dynamic obstacles (autowarefoundation#4892)

* visualize debug info for safety check

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Update planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

* fix build error

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants