Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(start/goal_planner): use combineLanelets #4894

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 5, 2023

Description

use combineLanelets for similar proccesing.

Tests performed

https://evaluation.tier4.jp/evaluation/reports/7c5294ef-2b39-58e7-8c87-eb32d83ca475?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 5, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (30ec8f7) 15.17% compared to head (fd46f99) 15.13%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4894      +/-   ##
==========================================
- Coverage   15.17%   15.13%   -0.04%     
==========================================
  Files        1578     1578              
  Lines      108584   108859     +275     
  Branches    33374    33593     +219     
==========================================
+ Hits        16475    16479       +4     
- Misses      74193    74291      +98     
- Partials    17916    18089     +173     
Flag Coverage Δ *Carryforward flag
differential 12.80% <0.00%> (?)
total 15.17% <ø> (+<0.01%) ⬆️ Carriedforward from 30ec8f7

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 6.66% <0.00%> (-2.43%) ⬇️
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.49% <0.00%> (-0.43%) ⬇️
..._planner/src/scene_module/goal_planner/manager.cpp 5.73% <0.00%> (-3.18%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 4.93% <0.00%> (-2.43%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 4.77% <0.00%> (-0.63%) ⬇️
...ner/src/utils/goal_planner/geometric_pull_over.cpp 20.83% <0.00%> (+0.83%) ⬆️
...nner/src/utils/start_goal_planner_common/utils.cpp 0.00% <0.00%> (ø)
...ner/src/utils/start_planner/geometric_pull_out.cpp 8.33% <ø> (+1.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit b1f1548 into main Sep 5, 2023
@kosuke55 kosuke55 deleted the refactor/use_combineLanelets branch September 5, 2023 17:18
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 7, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants