Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner): fix drivable area without shoulder lanes #4909

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 7, 2023

Description

fix drivable area of start planner when start from normal road lane witout shoulder lane.

before

image

after
image

Related links

Tests performed

psim

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 7, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 7, 2023
@kosuke55 kosuke55 changed the title fix(start_planner): fix pull out lanes without shoulder lanes fix(start_planner): fix drivable area without shoulder lanes Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (e9aacc3) 15.88% compared to head (b538c1a) 15.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4909   +/-   ##
=======================================
  Coverage   15.88%   15.88%           
=======================================
  Files        1578     1578           
  Lines      108904   108908    +4     
  Branches    33602    33603    +1     
=======================================
+ Hits        17301    17305    +4     
  Misses      73018    73018           
  Partials    18585    18585           
Flag Coverage Δ *Carryforward flag
differential 18.40% <50.00%> (?)
total 15.88% <ø> (+<0.01%) ⬆️ Carriedforward from e9aacc3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...cene_module/start_planner/start_planner_module.cpp 37.27% <50.00%> (+0.44%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit e73231d into main Sep 7, 2023
@satoshi-ota satoshi-ota deleted the fix/pull_out_lanes branch September 7, 2023 06:18
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 7, 2023
…efoundation#4909)

fix(start_planner): fix pull out lanes without shoulder lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…efoundation#4909)

fix(start_planner): fix pull out lanes without shoulder lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
…efoundation#4909)

fix(start_planner): fix pull out lanes without shoulder lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants