Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start/goal_planner): fix inverse order path points #4950

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 11, 2023

Description

shifting path make path point order wrong and is_driving_forward false, this causes wrong drivable area.
In this PR remove inverse position path point.

before

image

[component_container_mt-28] is_driving_forward in generateCombinedDrivableArea: 0
[component_container_mt-28] is_driving_forward: 0

image

after

image

image

Related links

https://tier4.atlassian.net/08ab1e03-283d-4096-9af4-08b3fd6658a6#media-blob-url=true&id=ef931a2e-2c9e-4636-a230-5e3759bab867&contextId=86702&collection=

Tests performed

https://evaluation.tier4.jp/evaluation/reports/66d65d25-8bad-5657-ab02-52686ca71601?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/09e72de7-3ce1-5d09-8582-af3915e70d12?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55
Copy link
Contributor Author

merge after #4929

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 11, 2023
@kosuke55 kosuke55 changed the title Fix/inverse order shifted path fix(start_planner): fix inverse order path points Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 36.36% and no project coverage change.

Comparison is base (82006db) 15.80% compared to head (65ac548) 15.80%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4950   +/-   ##
=======================================
  Coverage   15.80%   15.80%           
=======================================
  Files        1580     1580           
  Lines      109179   109190   +11     
  Branches    33646    33653    +7     
=======================================
+ Hits        17258    17262    +4     
- Misses      73313    73315    +2     
- Partials    18608    18613    +5     
Flag Coverage Δ *Carryforward flag
differential 17.68% <36.36%> (?)
total 15.80% <ø> (ø) Carriedforward from 82006db

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...planner/src/utils/goal_planner/shift_pull_over.cpp 3.53% <0.00%> (-0.04%) ⬇️
...planner/src/utils/start_planner/shift_pull_out.cpp 45.56% <0.00%> (-0.30%) ⬇️
...optimizer/src/static_centerline_optimizer_node.cpp 15.76% <ø> (ø)
...nner/src/utils/start_goal_planner_common/utils.cpp 39.39% <44.44%> (+0.79%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the fix/inverse_order_shifted_path branch from 34d50ea to 5cbde40 Compare September 12, 2023 02:56
@kosuke55 kosuke55 changed the title fix(start_planner): fix inverse order path points fix(start/goal_planner): fix inverse order path points Sep 12, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/inverse_order_shifted_path branch from 5cbde40 to 65ac548 Compare September 12, 2023 05:27
@kosuke55 kosuke55 merged commit 8798d5c into main Sep 12, 2023
@kosuke55 kosuke55 deleted the fix/inverse_order_shifted_path branch September 12, 2023 08:38
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…ation#4950)

fix(start_planner): fix inverse order path points

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request Sep 12, 2023
…ation#4950)

fix(start_planner): fix inverse order path points

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…ation#4950)

fix(start_planner): fix inverse order path points

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
…ation#4950)

fix(start_planner): fix inverse order path points

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
…ation#4950)

fix(start_planner): fix inverse order path points

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants