-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(start/goal_planner): fix inverse order path points #4950
Conversation
merge after #4929 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4950 +/- ##
=======================================
Coverage 15.80% 15.80%
=======================================
Files 1580 1580
Lines 109179 109190 +11
Branches 33646 33653 +7
=======================================
+ Hits 17258 17262 +4
- Misses 73313 73315 +2
- Partials 18608 18613 +5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
34d50ea
to
5cbde40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
5cbde40
to
65ac548
Compare
…ation#4950) fix(start_planner): fix inverse order path points Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4950) fix(start_planner): fix inverse order path points Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4950) fix(start_planner): fix inverse order path points Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4950) fix(start_planner): fix inverse order path points Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4950) fix(start_planner): fix inverse order path points Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
shifting path make path point order wrong and is_driving_forward false, this causes wrong drivable area.
In this PR remove inverse position path point.
before
after
Related links
https://tier4.atlassian.net/08ab1e03-283d-4096-9af4-08b3fd6658a6#media-blob-url=true&id=ef931a2e-2c9e-4636-a230-5e3759bab867&contextId=86702&collection=
Tests performed
https://evaluation.tier4.jp/evaluation/reports/66d65d25-8bad-5657-ab02-52686ca71601?project_id=prd_jt
https://evaluation.tier4.jp/evaluation/reports/09e72de7-3ce1-5d09-8582-af3915e70d12?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.