Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix occpancy grid initializing check #4969

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 12, 2023

Description

fix occpancy grid initializing check

Tests performed

psim with use_occupancy_grid: false

2023/09/12 https://evaluation.tier4.jp/evaluation/reports/79b3b226-04aa-573d-9761-420ec895925f/?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 12, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 5.55% and project coverage change: -0.01% ⚠️

Comparison is base (bcf52e0) 15.82% compared to head (6c2eda7) 15.82%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4969      +/-   ##
==========================================
- Coverage   15.82%   15.82%   -0.01%     
==========================================
  Files        1580     1580              
  Lines      109212   109241      +29     
  Branches    33673    33688      +15     
==========================================
+ Hits        17286    17287       +1     
- Misses      73312    73338      +26     
- Partials    18614    18616       +2     
Flag Coverage Δ *Carryforward flag
differential 17.79% <5.55%> (?)
total 15.82% <ø> (-0.01%) ⬇️ Carriedforward from bcf52e0

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp 13.33% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 8.53% <0.00%> (-0.29%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 30.20% <33.33%> (+0.01%) ⬆️
planning/behavior_path_planner/src/utils/utils.cpp 18.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit c7b5140 into main Sep 12, 2023
@kosuke55 kosuke55 deleted the fix/occupancy_grid branch September 12, 2023 15:11
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants