-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception): rearrange clustering pipeline #4999
refactor(perception): rearrange clustering pipeline #4999
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
==========================================
- Coverage 15.74% 15.71% -0.04%
==========================================
Files 1587 1592 +5
Lines 109796 110033 +237
Branches 33730 33730
==========================================
Hits 17288 17288
- Misses 73883 74120 +237
Partials 18625 18625
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
launch/tier4_perception_launch/launch/object_recognition/detection/detection.launch.xml
Outdated
Show resolved
Hide resolved
It is not change in this PR, but one question. Lines 129 to 134 in 3d3aa4f
|
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
...on_launch/launch/object_recognition/detection/camera_lidar_fusion_based_detection.launch.xml
Show resolved
Hide resolved
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@miursh It seems the estimated shape isn't used in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on#4999) * fix: change downsample filter Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: remove downsamle after compare map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add low range cropbox Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * refactor: use_pointcloud_map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add roi based clustering option Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: change node name Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: launch argument pasrer Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
…on#4999) * fix: change downsample filter Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: remove downsamle after compare map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add low range cropbox Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * refactor: use_pointcloud_map Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: refactor Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: add roi based clustering option Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * chore: change node name Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * fix: launch argument pasrer Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
refactor(perception): rearrange clustering pipeline (autowarefoundation#4999)
Description
This PR rearrange
downsample_filter
in clustering pipeline and add low_range_crop_filter to limit hight pointcloud before Euclidean cluster.Realated link
TIER IV INTERNAL LINK
slack
ticket
Releated PR
Tests performed
Tested result by logging_simulator using internal data.
![image](https://private-user-images.githubusercontent.com/94814556/267984943-d2e7eabb-bfff-4a1d-97dd-a0acd27e9813.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTcyNjEsIm5iZiI6MTczOTU5Njk2MSwicGF0aCI6Ii85NDgxNDU1Ni8yNjc5ODQ5NDMtZDJlN2VhYmItYmZmZi00YTFkLTk3ZGQtYTBhY2QyN2U5ODEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1MjI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjZGJjZTAyZTcyM2VlNjRhNjEwNTJmZjQ1ZWY4M2EwOTIyNDExOTgwMDg0YTgzNWJkZWU4MDI1YzU3MWVkMjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.N4uNGBLXXeRq15LbEjaTuEyanuSnxAaPQixvVz-iQXk)
perception_mode: camera_lidar_fusion_based
perception_mode: lidar_based
![image](https://private-user-images.githubusercontent.com/94814556/267986022-530cd0bf-9423-4c32-a192-d02aa73851b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTcyNjEsIm5iZiI6MTczOTU5Njk2MSwicGF0aCI6Ii85NDgxNDU1Ni8yNjc5ODYwMjItNTMwY2QwYmYtOTQyMy00YzMyLWExOTItZDAyYWE3Mzg1MWI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1MjI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5ZjNjOWEzM2EzODc3OGJmMjljNmNhNmY4ODZjZDQyNjY5ZjcyMjBmOTdjMmM2OGIwYjRiZTlhNmYxYTA2MzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.W4ReRl5sLI21KuMj8URfhEss8nxCMP-Uxk5USjjpReI)
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.