Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(perception): rearrange clustering pipeline #4999

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Sep 14, 2023

Description

This PR rearrange downsample_filter in clustering pipeline and add low_range_crop_filter to limit hight pointcloud before Euclidean cluster.

Realated link

TIER IV INTERNAL LINK
slack
ticket

Releated PR

Tests performed

Tested result by logging_simulator using internal data.
perception_mode: camera_lidar_fusion_based
image

perception_mode: lidar_based
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Sep 14, 2023
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen marked this pull request as ready for review September 14, 2023 13:41
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (6e510b4) 15.74% compared to head (a0b6c7b) 15.71%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4999      +/-   ##
==========================================
- Coverage   15.74%   15.71%   -0.04%     
==========================================
  Files        1587     1592       +5     
  Lines      109796   110033     +237     
  Branches    33730    33730              
==========================================
  Hits        17288    17288              
- Misses      73883    74120     +237     
  Partials    18625    18625              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.74% <ø> (ø) Carriedforward from 9639f8a

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@miursh
Copy link
Contributor

miursh commented Sep 15, 2023

It is not change in this PR, but one question.
Is this shape_estimation node necessary?

<group>
<include file="$(find-pkg-share shape_estimation)/launch/shape_estimation.launch.xml">
<arg name="input/objects" value="clusters"/>
<arg name="output/objects" value="objects_with_feature"/>
</include>
</group>

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen
Copy link
Contributor Author

It is not change in this PR, but one question. Is this shape_estimation node necessary?

<group>
<include file="$(find-pkg-share shape_estimation)/launch/shape_estimation.launch.xml">
<arg name="input/objects" value="clusters"/>
<arg name="output/objects" value="objects_with_feature"/>
</include>
</group>

@miursh It seems the estimated shape isn't used in detection_by_tracker so I think it is unneccessary. I will check carefully and changed it in another PR.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 8eeb11d into autowarefoundation:main Sep 19, 2023
miursh pushed a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
…on#4999)

* fix: change downsample filter

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove downsamle after compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add low range cropbox

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* refactor: use_pointcloud_map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add roi based clustering option

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: change node name

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: launch argument pasrer

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
…on#4999)

* fix: change downsample filter

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: remove downsamle after compare map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add low range cropbox

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* refactor: use_pointcloud_map

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: refactor

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: add roi based clustering option

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* chore: change node name

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: launch argument pasrer

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
miursh added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants