Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(radar_object_tracker): fix spell-check error #5024

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 19, 2023

Description

  • Fix spell-check errors for radar_object_tracker

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 19, 2023
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 19, 2023
@kminoda kminoda changed the title chore(radar_object_tracker): fix spell-check error and enable perception directory spell-check chore(radar_object_tracker): fix spell-check error and finally enable perception directory spell-check Sep 19, 2023
@kminoda kminoda marked this pull request as ready for review September 19, 2023 01:33
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07% ⚠️

Comparison is base (aae343b) 15.71% compared to head (b409487) 15.64%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5024      +/-   ##
==========================================
- Coverage   15.71%   15.64%   -0.07%     
==========================================
  Files        1579     1586       +7     
  Lines      109343   109272      -71     
  Branches    34110    33477     -633     
==========================================
- Hits        17183    17099      -84     
- Misses      73247    73622     +375     
+ Partials    18913    18551     -362     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.65% <ø> (-0.07%) ⬇️ Carriedforward from e6cdac0

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...racker/src/tracker/model/linear_motion_tracker.cpp 0.00% <0.00%> (ø)
...rc/utils/path_safety_checker/objects_filtering.cpp 21.67% <ø> (-3.66%) ⬇️

... and 99 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda
Copy link
Contributor Author

kminoda commented Sep 19, 2023

@yukkysaito @YoshiRi @scepter914 Would you mind reviewing this PR?

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except commented part.

.cspell-partial.json Outdated Show resolved Hide resolved
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda changed the title chore(radar_object_tracker): fix spell-check error and finally enable perception directory spell-check chore(radar_object_tracker): fix spell-check error Sep 20, 2023
@kminoda kminoda enabled auto-merge (squash) September 20, 2023 00:31
@kminoda kminoda merged commit 33dcea4 into autowarefoundation:main Sep 20, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Sep 20, 2023
…n#5024)

* chore(radar_object_tracker): fix spell-check errors

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* Finally perception directory has been removed from cspell ignorance

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* revert fix of spell-check dict

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kminoda kminoda deleted the chore/spell-check/radar_object_tracker branch September 26, 2023 01:35
miursh pushed a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2023
…n#5024)

* chore(radar_object_tracker): fix spell-check errors

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* Finally perception directory has been removed from cspell ignorance

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* style(pre-commit): autofix

* revert fix of spell-check dict

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants