-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(radar_object_tracker): fix spell-check error #5024
chore(radar_object_tracker): fix spell-check error #5024
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5024 +/- ##
==========================================
- Coverage 15.71% 15.64% -0.07%
==========================================
Files 1579 1586 +7
Lines 109343 109272 -71
Branches 34110 33477 -633
==========================================
- Hits 17183 17099 -84
- Misses 73247 73622 +375
+ Partials 18913 18551 -362
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@yukkysaito @YoshiRi @scepter914 Would you mind reviewing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except commented part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…n#5024) * chore(radar_object_tracker): fix spell-check errors Signed-off-by: kminoda <koji.minoda@tier4.jp> * Finally perception directory has been removed from cspell ignorance Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * revert fix of spell-check dict Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…n#5024) * chore(radar_object_tracker): fix spell-check errors Signed-off-by: kminoda <koji.minoda@tier4.jp> * Finally perception directory has been removed from cspell ignorance Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * revert fix of spell-check dict Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Tests performed
Not applicable
Effects on system behavior
Not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.