Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): calculate road shoulder distance for prev and next lanelet #5226

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 5, 2023

Description

🤖 Generated by Copilot at 040b8d9

Refactored utils.cpp to extend distance calculation to all lanelets that an object overhangs. This improves the object filtering for collision avoidance.

related link: TIER IV INTERNAL LINK


Before this PR, the distance between overhang point and road shoulder is not calculated properly because the module only checks intersection area bound of overhang lanelet but not for prev & next one.

Screencast.from.2023.10.24.16.02.26.webm

Tests performed

image

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 5, 2023
@satoshi-ota satoshi-ota force-pushed the fix/road-shoulder-distance branch from 040b8d9 to fb4595a Compare October 24, 2023 12:38
…nelet

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/road-shoulder-distance branch from fb4595a to 6a05855 Compare October 24, 2023 12:40
@satoshi-ota satoshi-ota marked this pull request as ready for review October 24, 2023 12:42
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (db27686) 14.80% compared to head (6a05855) 14.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5226      +/-   ##
==========================================
- Coverage   14.80%   14.80%   -0.01%     
==========================================
  Files        1661     1661              
  Lines      115448   115459      +11     
  Branches    35642    35647       +5     
==========================================
  Hits        17093    17093              
- Misses      79109    79120      +11     
  Partials    19246    19246              
Flag Coverage Δ *Carryforward flag
differential 12.66% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from db27686

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 13.59% <0.00%> (-0.05%) ⬇️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 11.39% <0.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@satoshi-ota satoshi-ota merged commit a995f98 into autowarefoundation:main Oct 26, 2023
@satoshi-ota satoshi-ota deleted the fix/road-shoulder-distance branch October 26, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants