Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_stop_planner, dynamic avoidance): fix coordinate transformation bug #5248

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Oct 6, 2023

Description

fix a bug same as fixed in #5180

Tests performed

psim test was performed.
Internal values were appropriate.

Effects on system behavior

Be able to properly handle an oncoming vehicle.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 6, 2023
@yuki-takagi-66 yuki-takagi-66 changed the title fix(obstacle_stop_planne, dynamic avoidancer): fix coordinate transformation bag fix(obstacle_stop_planne, dynamic avoidancer): fix coordinate transformation bug Oct 10, 2023
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d36be55) 14.76% compared to head (eeff304) 14.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5248      +/-   ##
==========================================
+ Coverage   14.76%   14.82%   +0.05%     
==========================================
  Files        1662     1648      -14     
  Lines      115411   113715    -1696     
  Branches    35614    35175     -439     
==========================================
- Hits        17044    16861     -183     
+ Misses      79145    77903    -1242     
+ Partials    19222    18951     -271     
Flag Coverage Δ *Carryforward flag
differential 11.93% <0.00%> (?)
total 14.79% <ø> (+0.02%) ⬆️ Carriedforward from a145788

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...tacle_stop_planner/src/adaptive_cruise_control.cpp 1.47% <0.00%> (-0.01%) ⬇️

... and 96 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota changed the title fix(obstacle_stop_planne, dynamic avoidancer): fix coordinate transformation bug fix(obstacle_stop_planner, dynamic avoidance): fix coordinate transformation bug Oct 20, 2023
@yuki-takagi-66 yuki-takagi-66 merged commit 915d47d into autowarefoundation:main Oct 20, 2023
@yuki-takagi-66 yuki-takagi-66 deleted the fix/takagi-coordinate-bagfix branch October 20, 2023 07:42
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…rmation bug (autowarefoundation#5248)

fix a known bug autowarefoundation#5180

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…rmation bug (autowarefoundation#5248)

fix a known bug autowarefoundation#5180

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants