Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drivable_area_expansion): fix max_arc_length parameter and extra_arc_length parameters #5333

Conversation

maxime-clem
Copy link
Contributor

Description

This PR fixes bugs with the max_arc_length and extra_arc_length parameters.

  • Path points are now initially cropped using the max_arc_length parameter.
  • max_arc_length = 0.0 is correctly handled as meaning "no limit on the path arc length".
  • arc length is correctly calculated when moving up the bound to apply the expansion distance to extra bound points following the extra_arc_length parameter.

Tests performed

Psim

Effects on system behavior

Parameters now work correctly.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 17, 2023
@maxime-clem maxime-clem changed the title fix(drivable_area_expansion): fix max_arc_length parameter fix(drivable_area_expansion): fix max_arc_length parameter and extra_arc_length parameters Oct 17, 2023
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 17, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0c7ef98) 14.77% compared to head (d0affca) 14.80%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5333      +/-   ##
==========================================
+ Coverage   14.77%   14.80%   +0.02%     
==========================================
  Files        1663     1663              
  Lines      115155   115929     +774     
  Branches    35519    36090     +571     
==========================================
+ Hits        17012    17160     +148     
- Misses      78935    79399     +464     
- Partials    19208    19370     +162     
Flag Coverage Δ *Carryforward flag
differential 12.25% <58.33%> (?)
total 14.77% <ø> (-0.01%) ⬇️ Carriedforward from 0c7ef98

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...rivable_area_expansion/drivable_area_expansion.cpp 44.02% <58.33%> (+1.16%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 86a5954 into autowarefoundation:main Oct 17, 2023
@maxime-clem maxime-clem deleted the fix/dynamic_drivable_area_expansion-max_arc_length-awf branch October 17, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants