Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ndt_scan_matcher): add test_ndt_scan_matcher_launch.py #5347

Conversation

SakodaShintaro
Copy link
Contributor

Description

Add a test test_ndt_scan_matcher_launch.py that only checks the launch of the ndt_scan_matcher node.

With this change, the checking of services in the constructor of MapUpdateModule will be changed to checking before the actual service call.

It is somewhat useless to check every time, but I did this because the constructor cannot terminate in test.

Tests performed

It has been confirmed that the following commands can be executed successfully.

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON --packages-select ndt_scan_matcher
colcon test --packages-select ndt_scan_matcher
colcon test-result --all --verbose | grep ndt_scan_matcher

I also confirmed that double declarations of parameters will cause the test to fail NG.

In addition, it has been confirmed that AWSIM and logging_simulator can run successfully.

Effects on system behavior

There is no effects on system behavior since it is just an additional test.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Oct 18, 2023
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 18, 2023
@SakodaShintaro SakodaShintaro self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c6278ce) 14.76% compared to head (388c4c5) 14.77%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5347      +/-   ##
==========================================
+ Coverage   14.76%   14.77%   +0.01%     
==========================================
  Files        1662     1663       +1     
  Lines      115290   115094     -196     
  Branches    35543    35537       -6     
==========================================
- Hits        17018    17008      -10     
+ Misses      79053    78879     -174     
+ Partials    19219    19207      -12     
Flag Coverage Δ *Carryforward flag
differential 7.11% <0.00%> (?)
total 14.77% <ø> (+0.01%) ⬆️ Carriedforward from ff9dd0f

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ization/ndt_scan_matcher/src/map_update_module.cpp 0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SakodaShintaro SakodaShintaro merged commit eaf9f68 into autowarefoundation:main Oct 19, 2023
@SakodaShintaro SakodaShintaro deleted the feat/add_launch_test_to_ndt_scan_matcher branch October 19, 2023 03:58
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Nov 16, 2023
…foundation#5347)

* Added test_ndt_scan_matcher_launch.py

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added assert and raising exception

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Nov 16, 2023
…foundation#5347)

* Added test_ndt_scan_matcher_launch.py

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* Added assert and raising exception

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

---------

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants