-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ndt_scan_matcher): add test_ndt_scan_matcher_launch.py #5347
test(ndt_scan_matcher): add test_ndt_scan_matcher_launch.py #5347
Conversation
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5347 +/- ##
==========================================
+ Coverage 14.76% 14.77% +0.01%
==========================================
Files 1662 1663 +1
Lines 115290 115094 -196
Branches 35543 35537 -6
==========================================
- Hits 17018 17008 -10
+ Misses 79053 78879 -174
+ Partials 19219 19207 -12
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
localization/ndt_scan_matcher/test/test_ndt_scan_matcher_launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundation#5347) * Added test_ndt_scan_matcher_launch.py Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added assert and raising exception Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…foundation#5347) * Added test_ndt_scan_matcher_launch.py Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> * Added assert and raising exception Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> --------- Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Description
Add a test
test_ndt_scan_matcher_launch.py
that only checks the launch of thendt_scan_matcher
node.With this change, the checking of services in the constructor of MapUpdateModule will be changed to checking before the actual service call.
It is somewhat useless to check every time, but I did this because the constructor cannot terminate in test.
Tests performed
It has been confirmed that the following commands can be executed successfully.
I also confirmed that double declarations of parameters will cause the test to fail NG.
In addition, it has been confirmed that AWSIM and logging_simulator can run successfully.
Effects on system behavior
There is no effects on system behavior since it is just an additional test.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.