Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route_handler): filter out start lanelets wrt start checkpoint orientation #5358

Conversation

mehmetdogru
Copy link
Contributor

Description

closes #5357

What this PR changes?

  • route_handler filters start_lanelet's to eliminate improper oriented ones wrt start_checkpoint

Related links

Tests performed

cap-after.mp4

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mehmetdogru mehmetdogru added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 19, 2023
@mehmetdogru mehmetdogru self-assigned this Oct 19, 2023
…ientation

Signed-off-by: Mehmet Dogru <mdogru@leodrive.ai>
@mehmetdogru mehmetdogru force-pushed the 5357-filter-out-start-lanelets-wrt-start-checkpoint-orientation branch from d508186 to 7687286 Compare October 20, 2023 07:03
@mehmetdogru mehmetdogru added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d36be55) 14.76% compared to head (7687286) 14.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5358   +/-   ##
=======================================
  Coverage   14.76%   14.76%           
=======================================
  Files        1662     1662           
  Lines      115411   115414    +3     
  Branches    35614    35616    +2     
=======================================
+ Hits        17044    17045    +1     
  Misses      79145    79145           
- Partials    19222    19224    +2     
Flag Coverage Δ *Carryforward flag
differential 15.09% <25.00%> (?)
total 14.76% <ø> (+<0.01%) ⬆️ Carriedforward from d36be55

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
planning/route_handler/src/route_handler.cpp 25.07% <25.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shmpwk shmpwk enabled auto-merge (squash) October 20, 2023 12:36
@shmpwk shmpwk disabled auto-merge October 20, 2023 12:36
@shmpwk shmpwk merged commit 89ae3bb into autowarefoundation:main Oct 20, 2023
@mehmetdogru mehmetdogru deleted the 5357-filter-out-start-lanelets-wrt-start-checkpoint-orientation branch October 20, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

route handler does not consider the angle between start_checkpoint and start_lanelet
2 participants