-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(motion_utils): faster removeOverlapPoints and calcLateralOffset functions #5385
Merged
maxime-clem
merged 7 commits into
autowarefoundation:main
from
maxime-clem:benchmark/calcLateralOffset
Nov 10, 2023
Merged
perf(motion_utils): faster removeOverlapPoints and calcLateralOffset functions #5385
maxime-clem
merged 7 commits into
autowarefoundation:main
from
maxime-clem:benchmark/calcLateralOffset
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark should be run with command ./build/motion_utils/test_motion_utils --gtest_filter=trajectory_benchmark.\* --gtest_also_run_disabled_tests Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
TakaHoribe
approved these changes
Oct 24, 2023
TakaHoribe
reviewed
Oct 24, 2023
common/motion_utils/test/src/trajectory/benchmark_calcLateralOffset.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5385 +/- ##
==========================================
- Coverage 14.76% 14.76% -0.01%
==========================================
Files 1662 1663 +1
Lines 115457 116135 +678
Branches 35639 36018 +379
==========================================
+ Hits 17047 17142 +95
- Misses 79181 79695 +514
- Partials 19229 19298 +69
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 22, 2023
…functions (autowarefoundation#5385) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
removeOverlapPoints
andcalcLateralOffset
functions faster, simply by callingreserve
on the vector created inremoveOverlapPoints
.Tests performed
Benchmark test (disabled by default) was added. It calls the function 10000 times on a trajectory with 1000 points.
To test on you local machine:
Effects on system behavior
None.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.