feat(planning_topic_converter): add new package #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
satoshi-ota
force-pushed
the
feat/planning-topic-converter
branch
from
36f3579 to
31c9884
Compare
kosuke55
approved these changes
Nov 6, 2023
Comment on lines
17
to
18
| <param name="input_topic" value="hoge"/> | ||
| <param name="output_topic" value="fuga"/> |
There was a problem hiding this comment.
(nits: only Japanese know hoge/fuga)
Comment on lines
+24
to
+32
| TrajectoryPoint convertToTrajectoryPoint(const PathPoint & point) | ||
| { | ||
| TrajectoryPoint traj_point; | ||
| traj_point.pose = tier4_autoware_utils::getPose(point); | ||
| traj_point.longitudinal_velocity_mps = point.longitudinal_velocity_mps; | ||
| traj_point.lateral_velocity_mps = point.lateral_velocity_mps; | ||
| traj_point.heading_rate_rps = point.heading_rate_rps; | ||
| return traj_point; | ||
| } |
There was a problem hiding this comment.
(similar functions exist in other motion planner nodes, so better to use them as utils in the future)
There was a problem hiding this comment.
I totally agree with you. Create tickets to remind that task.
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
feat/planning-topic-converter
branch
from
31c9884 to
0bae12b
Compare
satoshi-ota
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5484 +/- ##
==========================================
- Coverage 14.86% 14.85% -0.01%
==========================================
Files 1666 1668 +2
Lines 116258 116286 +28
Branches 36266 36266
==========================================
Hits 17277 17277
- Misses 79476 79504 +28
Partials 19505 19505
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 36f3579
This pull request adds a new package called
planning_topic_converter, which provides a common interface and a concrete implementation for converting planning topics from one type to another. The package consists of a CMakeLists.txt file, a package.xml file, a README.md file, and two header and source files for the base and derived classes. The package also supports composable ROS 2 nodes.Tests performed
Psim
Effects on system behavior
Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.