Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dynamic_avoidance): support new interface #5527

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 9, 2023

Description

🤖 Generated by Copilot at 7532982

Refactored DynamicAvoidanceModule class in behavior_path_planner package to simplify and optimize dynamic obstacle avoidance. Removed unused and redundant functions and improved variable access and state transition logic.

related ticket: https://tier4.atlassian.net/browse/RT1-3401

Tests performed

image

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 9, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review November 9, 2023 04:47
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5797ee5) 15.37% compared to head (7532982) 15.39%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5527      +/-   ##
==========================================
+ Coverage   15.37%   15.39%   +0.02%     
==========================================
  Files        1697     1697              
  Lines      117488   118137     +649     
  Branches    37762    38233     +471     
==========================================
+ Hits        18062    18192     +130     
- Misses      78858    79288     +430     
- Partials    20568    20657      +89     
Flag Coverage Δ *Carryforward flag
differential 12.74% <0.00%> (?)
total 15.37% <ø> (+<0.01%) ⬆️ Carriedforward from 5797ee5

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 9.09% <ø> (+1.27%) ⬆️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 3.18% <0.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 2cbd0c3 into autowarefoundation:main Nov 9, 2023
@satoshi-ota satoshi-ota deleted the refactor/dynamic-avoidance-interface branch November 9, 2023 10:12
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
…n#5527)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants