Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix extending current lanes #5595

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 15, 2023

Description

need to extend after original goal for modifid goal.

fix

https://evaluation.tier4.jp/evaluation/reports/8eeaa795-f1ca-5a26-81cc-492c7b4078a3/tests/753aa082-6f6e-528e-827d-12aabe6c616a/bcd56260-8454-57f7-b3a7-fd7f0a21ef4f/ea234da3-27e3-5bf9-9da1-042b56c60690?project_id=prd_jt

image

Related links

Tests performed

psim

evaluator_description: fix/goal_planner_current_lanes
2023/11/15 https://evaluation.tier4.jp/evaluation/reports/b61a0925-c518-5ba3-ba8d-954f7b9c9f83/?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 15, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 15, 2023
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 enabled auto-merge (squash) November 15, 2023 15:43
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (e3c2603) 15.32%.
Report is 6 commits behind head on main.

Files Patch % Lines
.../scene_module/goal_planner/goal_planner_module.cpp 0.00% 6 Missing ⚠️
...rivable_area_expansion/drivable_area_expansion.cpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5595      +/-   ##
==========================================
- Coverage   15.32%   15.32%   -0.01%     
==========================================
  Files        1721     1721              
  Lines      118559   118561       +2     
  Branches    37995    37999       +4     
==========================================
- Hits        18169    18168       -1     
  Misses      79657    79657              
- Partials    20733    20736       +3     
Flag Coverage Δ *Carryforward flag
differential 12.69% <18.18%> (?)
total 15.32% <40.00%> (-0.01%) ⬇️ Carriedforward from 017aed4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 2a1ad67 into main Nov 15, 2023
@kosuke55 kosuke55 deleted the fix/goal_planner_current_lanes branch November 15, 2023 18:54
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 22, 2023
* fix(goal_planner): fix extending current lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix build error

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants