Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): check moving distance #5922

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 19, 2023

Description

Related PR: autowarefoundation/autoware_launch#747

Avoidance module basically avoid only objects that have offset from current lane (e.g. parked vehicle on road shoulder). But sometimes we met the situation where it is difficult to judge whether the vehicle is parked or not by only their shift length. In that case, avoidance module checks the time duration since the object speed is less than threshold.

However, following behavior is caused by this feature.

simplescreenrecorder-2023-12-20_09.22.31.mp4

In this PR, I added another condition to that feature, and check moving distance. If the object moves more than threshold, avoidance module judges the object is NOT parked vehicle and ignore it even if its speed is less than threshold.

Tests performed

Psim

object has small speed.

simplescreenrecorder-2023-12-20_09.16.41.mp4

object completely stopped.

simplescreenrecorder-2023-12-20_09.16.04.mp4

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 19, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review December 20, 2023 00:09
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/check-moving-distance branch from af676fe to 76f9ba0 Compare December 20, 2023 04:28
@satoshi-ota satoshi-ota enabled auto-merge (squash) December 20, 2023 04:29
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (c9b9fca) 15.29% compared to head (76f9ba0) 15.30%.
Report is 9 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/utils.cpp 0.00% 11 Missing ⚠️
...ehavior_path_avoidance_module/parameter_helper.hpp 0.00% 0 Missing and 2 partials ⚠️
...nning/behavior_path_avoidance_module/src/scene.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5922   +/-   ##
=======================================
  Coverage   15.29%   15.30%           
=======================================
  Files        1748     1748           
  Lines      120279   120253   -26     
  Branches    36673    36643   -30     
=======================================
  Hits        18399    18399           
+ Misses      81247    81243    -4     
+ Partials    20633    20611   -22     
Flag Coverage Δ *Carryforward flag
differential 13.42% <0.00%> (?)
total 15.30% <ø> (+<0.01%) ⬆️ Carriedforward from c9b9fca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 6c443ab into autowarefoundation:main Dec 20, 2023
20 of 24 checks passed
@satoshi-ota satoshi-ota deleted the feat/check-moving-distance branch December 20, 2023 22:56
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants