-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): check moving distance #5922
fix(avoidance): check moving distance #5922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
af676fe
to
76f9ba0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5922 +/- ##
=======================================
Coverage 15.29% 15.30%
=======================================
Files 1748 1748
Lines 120279 120253 -26
Branches 36673 36643 -30
=======================================
Hits 18399 18399
+ Misses 81247 81243 -4
+ Partials 20633 20611 -22
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Related PR: autowarefoundation/autoware_launch#747
Avoidance module basically avoid only objects that have offset from current lane (e.g. parked vehicle on road shoulder). But sometimes we met the situation where it is difficult to judge whether the vehicle is parked or not by only their shift length. In that case, avoidance module checks the time duration since the object speed is less than threshold.
However, following behavior is caused by this feature.
simplescreenrecorder-2023-12-20_09.22.31.mp4
In this PR, I added another condition to that feature, and check moving distance. If the object moves more than threshold, avoidance module judges the object is NOT parked vehicle and ignore it even if its speed is less than threshold.
Tests performed
Psim
object has small speed.
simplescreenrecorder-2023-12-20_09.16.41.mp4
object completely stopped.
simplescreenrecorder-2023-12-20_09.16.04.mp4
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.