Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(behavior_velocity): add include autoware utils #697

Merged
merged 1 commit into from
Apr 15, 2022
Merged

fix(behavior_velocity): add include autoware utils #697

merged 1 commit into from
Apr 15, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Apr 14, 2022 •
edited
Loading

Description

fix missing include of tier4_autoware_utils normalization.hpp
related to #620

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3
fix(behavior_velocity): add include autoware utils
662ad60 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 requested a review from 0x126 April 14, 2022 14:34
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #697 (662ad60) into main (f68121e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   10.54%   10.54%   -0.01%     
==========================================
  Files         741      741              
  Lines       51998    52009      +11     
  Branches     6652     6652              
==========================================
  Hits         5483     5483              
- Misses      42055    42066      +11     
  Partials     4460     4460
Flag Coverage Δ *Carryforward flag
differential 6.29% <ø> (?)
total 10.54% <ø> (ø) Carriedforward from f68121e

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/scene_module/occlusion_spot/grid_utils.hpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68121e...662ad60. Read the comment docs.

0x126
0x126 approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 154a4bb into autowarefoundation:main Apr 15, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 16, 2022
Merged
isamu-takagi pushed a commit to isamu-takagi/autoware.universe that referenced this pull request Apr 21, 2022
@taikitanaka3 @tkimura4
@kosuke55 @kmiya @TakaHoribe
feat: add accel brake map calibrator packages (autowarefoundation#80)
56da955 
* [accel brake map calibrator] sync main / .auto porting (autowarefoundation#697)

* Feature/add accel brake map calib (autowarefoundation#2287) (autowarefoundation#2342)

* Feature/add accel brake map calib (autowarefoundation#2287)

* add accel brake map calibrator

* UpdateAccelBrakeMap:calibration_msgs->vehicle_msgs

* remove dependency

* remove dependency

* add dependency

* remove pitch reader

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator_button_panel/src/accel_brake_map_calibrator_button_panel.hpp

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* unify Rviz description

* remove compile option

* Rviz -> RViz

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* add compile options

* add compile options

* use [[maybe_unused]] and add compile options

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/README.md

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml

* Update vehicle/accel_brake_map_calibrator/accel_brake_map_calibrator/launch/accel_brake_map_calibrator.launch.xml

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* Fix format

* Use autoware_lint_common

* Use using-declarations

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* add diagnostics to accel brake map calibrator (autowarefoundation#2308)

* fix dependency (autowarefoundation#2316)

* .auto porting

* fix readme

* fix comment

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* [accel brake map]update readme (autowarefoundation#755)

* update readme

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@taikitanaka3 taikitanaka3 deleted the fix-behavior-velocity-include branch June 6, 2022 09:21
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@taikitanaka3 @boyali
fix(behavior_velocity): add include autoware utils (tier4#697)
97ad8e0 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @boyali
fix(behavior_velocity): add include autoware utils (tier4#697)
19ae3b6 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@taikitanaka3 @boyali
fix(behavior_velocity): add include autoware utils (tier4#697)
df0cda5 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@taikitanaka3 @boyali
fix(behavior_velocity): add include autoware utils (tier4#697)
606628f 
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
@tier4-autoware-public-bot @yuki-takagi-66
@sebekx @xtk8532704
chore: sync awf-latest (autowarefoundation#697)
63bfe66 
* refactor(system_diagnostic_monitor, dummy_diag_publisher, diagnostic_graph_aggregator): combine diag list setting directories (autowarefoundation#1253)

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

* feat(object_lanelet_filter): add configurable margin for object lanel… (autowarefoundation#1210)

feat(object_lanelet_filter): add configurable margin for object lanelet filter

Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>

* fix(rviz): fix a bug about visualizing ego model (autowarefoundation#1257)

fix a visulization bug.

Signed-off-by: temkei.kem <1041084556@qq.com>

---------

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>
Signed-off-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
Signed-off-by: temkei.kem <1041084556@qq.com>
Co-authored-by: Yuki TAKAGI <141538661+yuki-takagi-66@users.noreply.github.com>
Co-authored-by: Sebastian Zęderowski <sebek.x@gmail.com>
Co-authored-by: Sebastian Zęderowski <szederowski@autonomous-systems.pl>
Co-authored-by: Kem (TiankuiXian) <1041084556@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x126 0x126 0x126 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taikitanaka3 @0x126