feat(psim)!: preapre settings to launch localization modules on psim #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:launch
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
yuki-takagi-66
added
the
run:build-and-test-differential
yuki-takagi-66
requested review from
soblin,
maxime-clem,
TakaHoribe,
tkimura4,
zulfaqar-azmi-t4,
KeisukeShima,
taikitanaka3 and
takayuki5168
as code owners
yuki-takagi-66
force-pushed
the
takagi/launch_localization_on_psim
branch
from
7c58c43 to
2c74c20
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8212 +/- ##
=======================================
Coverage 23.90% 23.91%
=======================================
Files 1381 1384 +3
Lines 101913 101940 +27
Branches 38810 38812 +2
=======================================
+ Hits 24363 24374 +11
Misses 75066 75066
- Partials 2484 2500 +16
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Jul 26, 2024
yuki-takagi-66
added
run:build-and-test-differential
yuki-takagi-66
force-pushed
the
takagi/launch_localization_on_psim
branch
from
2c74c20 to
67cc848
Compare
kosuke55
reviewed
Jul 26, 2024
Comment on lines
159
to
161
| <arg name="ndt_enabled" value="false"/> | ||
| <arg name="gnss_enabled" value="false"/> | ||
| <arg name="ekf_enabled" value="true"/> |
There was a problem hiding this comment.
localization modules without NDT will be launched.
not NDT but ekf?
There was a problem hiding this comment.
this is just pose_initializer's args. sorry I misunderstood
kosuke55
approved these changes
Jul 26, 2024
Comment on lines
159
to
161
| <arg name="ndt_enabled" value="false"/> | ||
| <arg name="gnss_enabled" value="false"/> | ||
| <arg name="ekf_enabled" value="true"/> |
There was a problem hiding this comment.
this is just pose_initializer's args. sorry I misunderstood
yuki-takagi-66
force-pushed
the
takagi/launch_localization_on_psim
branch
2 times, most recently
from
eb35996 to
69110b2
Compare
yuki-takagi-66
removed
the
run:build-and-test-differential
TakaHoribe
reviewed
Jul 26, 2024
yukkysaito
requested changes
Jul 29, 2024
There was a problem hiding this comment.
Same comment
autowarefoundation/autoware_launch#1094 (review)
yuki-takagi-66
force-pushed
the
takagi/launch_localization_on_psim
branch
2 times, most recently
from
7985c6d to
a136f54
Compare
yuki-takagi-66
changed the title
yuki-takagi-66
force-pushed
the
takagi/launch_localization_on_psim
branch
from
a136f54 to
04546f0
Compare
yuki-takagi-66
changed the title
yuki-takagi-66
changed the title
yuki-takagi-66
added
the
run:build-and-test-differential
TakaHoribe
approved these changes
Aug 19, 2024
yukkysaito
approved these changes
Aug 19, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66
force-pushed
the
takagi/launch_localization_on_psim
branch
from
3601844 to
9b03ebe
Compare
yuki-takagi-66
merged commit 776f5d8
into
autowarefoundation:main
29 of 30 checks passed
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 22, 2024
…utowarefoundation#8212) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…utowarefoundation#8212) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
kosuke55
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 29, 2024
…utowarefoundation#8212) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 18, 2024
…utowarefoundation#8212) Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a part of the following issue:
autowarefoundation/autoware_launch#1100
This PR allows localization and simple_planning_simulator to support launching the localization module in psim.
launch PR: autowarefoundation/autoware_launch#1094
For more details, please see the launch PR and the issue page.
How was this PR tested?
psim tests and scenario simulator
Notes for reviewers
None.
Interface changes
Effects on system behavior