feat(autonomous_emergency_braking): add info marker and override for state #8312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsanchezaran
requested review from
kyoichi-sugahara,
soblin,
TakaHoribe and
tkimura4
as code owners
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
kyoichi-sugahara
approved these changes
Aug 2, 2024
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8312 +/- ##
==========================================
- Coverage 15.09% 0.00% -15.10%
==========================================
Files 1967 127 -1840
Lines 135941 13720 -122221
Branches 42122 1477 -40645
==========================================
- Hits 20520 0 -20520
+ Misses 92700 13720 -78980
+ Partials 22721 0 -22721
☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
force-pushed
the
feat/add-aeb-info-marker
branch
from
a193940 to
8db417e
Compare
danielsanchezaran
merged commit c7432e1
into
autowarefoundation:main
29 of 30 checks passed
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 5, 2024
…state (autowarefoundation#8312) add info marker and override for state Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…state (autowarefoundation#8312) add info marker and override for state Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 11, 2024
…state (autowarefoundation#8312) add info marker and override for state Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 28, 2024
…state (autowarefoundation#8312) add info marker and override for state Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 14, 2024
…state (autowarefoundation#8312) add info marker and override for state Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates AEB module markers into info markers (stop wall) and debug markers (rest), the intention is to enable the AEB stop wall being visible by default.
Furthermore, this PR also adds the ability to toggle on and off autoware/state topic requirement for simulation, which can be useful to turn off when performing simulation tests。
Related links
Parent Issue:
How was this PR tested?
PSim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.