Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pcl_crop_box_filter): solve error in the subsequent module #836

Closed

Conversation

plane-li
Copy link
Contributor

@plane-li plane-li commented Apr 29, 2022

Description

This PR is used to solve the below issue: #705

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@plane-li plane-li changed the title fix(pcl_crop_box_filter) solve error in the subsequent module fix(pcl_crop_box_filter): solve error in the subsequent module Apr 29, 2022
@plane-li plane-li requested a review from Sharrrrk April 29, 2022 09:43
@Sharrrrk Sharrrrk added type:bug Software flaws or errors. component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Apr 29, 2022
@wep21 wep21 force-pushed the issue_#705_crop_box_filter branch from 18ab1eb to cdd64f0 Compare May 1, 2022 07:35
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #836 (7fcc66e) into main (bcfb8c5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #836      +/-   ##
========================================
- Coverage   9.58%   9.57%   -0.01%     
========================================
  Files        925     925              
  Lines      57410   57443      +33     
  Branches    6863    6863              
========================================
  Hits        5502    5502              
- Misses     47383   47416      +33     
  Partials    4525    4525              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.58% <0.00%> (ø) Carriedforward from bcfb8c5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...cessor/crop_box_filter/crop_box_filter_nodelet.hpp 0.00% <0.00%> (ø)
...or/src/crop_box_filter/crop_box_filter_nodelet.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfb8c5...7fcc66e. Read the comment docs.

@yukkysaito
Copy link
Contributor

@plane-li can you fix some fails of CI?

@plane-li plane-li force-pushed the issue_#705_crop_box_filter branch from cdd64f0 to 7fcc66e Compare May 6, 2022 10:14
@plane-li
Copy link
Contributor Author

plane-li commented May 7, 2022

@plane-li can you fix some fails of CI?

OK,sorry! Because the PR has been closed,I will do another PR.

@plane-li plane-li closed this May 7, 2022
@plane-li plane-li deleted the issue_#705_crop_box_filter branch May 7, 2022 02:31
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Sep 15, 2023
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
Signed-off-by: KhalilSelyan <khalilselyan2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants