Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(time_utils): fix unusedFunction #8606

Conversation

kobayu858
Copy link
Contributor

@kobayu858 kobayu858 commented Aug 26, 2024

Description

This is a fix based on cppcheck unusedFunction warnings.

common/time_utils/src/time_utils/time_utils.cpp:67:0: style: The function 'to_message' is never used. [unusedFunction]
builtin_interfaces::msg::Time to_message(const std::chrono::system_clock::time_point t)
^

common/time_utils/src/time_utils/time_utils.cpp:80:0: style: The function 'from_message' is never used. [unusedFunction]
std::chrono::system_clock::time_point from_message(builtin_interfaces::msg::Time t) noexcept
^

common/time_utils/src/time_utils/time_utils.cpp:67:0: style: The function 'to_message' is never used. [unusedFunction]
builtin_interfaces::msg::Time to_message(std::chrono::nanoseconds dt)
^

common/time_utils/src/time_utils/time_utils.cpp:80:0: style: The function 'from_message' is never used. [unusedFunction]
std::chrono::system_clock::time_point from_message(std::chrono::nanoseconds dt) noexcept
^

common/time_utils/src/time_utils/time_utils.cpp:25:0: style: The function 'duration_to_msg' is never used. [unusedFunction]
TimeT duration_to_msg(std::chrono::nanoseconds dt)
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.07%. Comparing base (b9b0fa9) to head (103aeeb).
Report is 84 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8606   +/-   ##
=======================================
  Coverage   24.06%   24.07%           
=======================================
  Files        1398     1398           
  Lines      102639   102617   -22     
  Branches    39023    39020    -3     
=======================================
  Hits        24704    24704           
+ Misses      75403    75381   -22     
  Partials     2532     2532           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 24.07% <ø> (+<0.01%) ⬆️ Carriedforward from b9b0fa9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 requested a review from veqcc August 26, 2024 04:36
@kobayu858
Copy link
Contributor Author

@shmpwk @tkimura4

Please confirm the PR. Thank you very much.

@tkimura4 tkimura4 merged commit 978ab43 into autowarefoundation:main Sep 2, 2024
43 checks passed
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_com-31 branch October 1, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants