fix(autoware_static_centerline_generator): fix unusedFunction #8647
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Aug 28, 2024 in 51s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.43 (8.26 -> 8.69)
- Improving Code Health: 2 findings(s) ✅
Details
✅ Improving Code Health:
- Complex Method static_centerline_generator_node.cpp: StaticCenterlineGeneratorNode::update_road_boundary
- Bumpy Road Ahead static_centerline_generator_node.cpp: StaticCenterlineGeneratorNode::update_road_boundary
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
StaticCenterlineGeneratorNode::update_road_boundary is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
StaticCenterlineGeneratorNode::update_road_boundary is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/autoware_static_centerline_generator/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 50.00% to 51.16%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Loading