-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_pointcloud_preprocessor): fix unusedFunction #8673
fix(autoware_pointcloud_preprocessor): fix unusedFunction #8673
Conversation
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8673 +/- ##
==========================================
- Coverage 24.19% 24.19% -0.01%
==========================================
Files 1400 1402 +2
Lines 102131 102166 +35
Branches 38779 38783 +4
==========================================
+ Hits 24710 24714 +4
- Misses 74917 74949 +32
+ Partials 2504 2503 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@yukkysaito could you take a look at this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since this code is based on the existing one, it might be better not to introduce too many differences.
https://github.com/martinus/robin-hood-hashing
…undation#8673) fix:unusedFunction Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
…undation#8673) fix:unusedFunction Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Description
This is a fix based on cppcheck unusedFunction warnings.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.