Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): fix unusedFunction #8673

Merged

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on cppcheck unusedFunction warnings.

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:344:0: style: The function 'rotr' is never used. [unusedFunction]
T rotr(T x, unsigned k)
^

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:1935:0: style: The function 'emplace_hint' is never used. [unusedFunction]
  iterator emplace_hint(const const_iterator & position, Args &&... args)
^

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2180:0: style: The function 'rehash' is never used. [unusedFunction]
  void rehash(size_t c)
^

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2196:0: style: The function 'compact' is never used. [unusedFunction]
  void compact()
^

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2234:0: style: The function 'max_load_factor' is never used. [unusedFunction]
  float max_load_factor() const noexcept
^

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2241:0: style: The function 'load_factor' is never used. [unusedFunction]
  float load_factor() const noexcept
^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Aug 29, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc August 29, 2024 08:57
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.19%. Comparing base (7011ea1) to head (48cbd0d).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8673      +/-   ##
==========================================
- Coverage   24.19%   24.19%   -0.01%     
==========================================
  Files        1400     1402       +2     
  Lines      102131   102166      +35     
  Branches    38779    38783       +4     
==========================================
+ Hits        24710    24714       +4     
- Misses      74917    74949      +32     
+ Partials     2504     2503       -1     
Flag Coverage Δ *Carryforward flag
differential 18.76% <ø> (?)
total 24.19% <ø> (ø) Carriedforward from 7011ea1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi
Copy link
Contributor

YoshiRi commented Aug 30, 2024

@yukkysaito could you take a look at this pr?

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Since this code is based on the existing one, it might be better not to introduce too many differences.
https://github.com/martinus/robin-hood-hashing

@vividf vividf merged commit 471d079 into autowarefoundation:main Aug 30, 2024
41 checks passed
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…undation#8673)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…undation#8673)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_sen-1 branch October 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants