Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_motion_utils): add clone function and make the constructor public #8688

Merged
merged 15 commits into from
Aug 30, 2024
Merged

feat(autoware_motion_utils): add clone function and make the constructor public #8688

merged 15 commits into from
Aug 30, 2024

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Aug 30, 2024 •
edited
Loading

Description

This PR contains 2 changes.

  1. Addition of clone function to do deep copy.
  2. Make the constructor public.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

yhisaki and others added 14 commits August 19, 2024 10:56
@yhisaki
feat(autoware_motion_utils): add interpolator
480951d 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
use int32_t instead of int
8f779ef 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
use int32_t instead of int
825e843 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
use int32_t instead of int
3ea857b 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
add const as much as possible and use at() in vector
846487f 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
fix directory name
c493c7e 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
refactor code and add example
c37a0f8 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
Merge branch 'main' into feat/interpolator
9728049
@yhisaki
update
d37d9b6 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
remove unused include
4f05276 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
refactor code
d08f207 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
add clone function
85c3846 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
fix stairstep
656d6fa 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki
make constructor to public
7c75e7c 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Aug 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki
Merge remote-tracking branch 'origin/main' into update-trajectory_con…
57dbf63 
…tainer

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki yhisaki changed the title Update trajectory container feat(autoware_motion_utils): add clone function and make constructor to public Aug 30, 2024
@yhisaki yhisaki changed the title feat(autoware_motion_utils): add clone function and make constructor to public feat(autoware_motion_utils): add clone function and make the constructor public Aug 30, 2024
@yhisaki yhisaki marked this pull request as ready for review August 30, 2024 06:30
@yhisaki yhisaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2024
@yhisaki yhisaki enabled auto-merge (squash) August 30, 2024 06:31
@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 24.16%. Comparing base (0cee961) to head (57dbf63).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ectory_container/interpolator/nearest_neighbor.hpp 33.33% 2 Missing ⚠️
...ls/trajectory_container/interpolator/stairstep.hpp 33.33% 2 Missing ⚠️
...trajectory_container/interpolator/akima_spline.cpp 0.00% 2 Missing ⚠️
...trajectory_container/interpolator/cubic_spline.cpp 0.00% 2 Missing ⚠️
...s/src/trajectory_container/interpolator/linear.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8688      +/-   ##
==========================================
- Coverage   24.16%   24.16%   -0.01%     
==========================================
  Files        1400     1400              
  Lines      102242   102262      +20     
  Branches    38758    38760       +2     
==========================================
+ Hits        24705    24708       +3     
- Misses      75064    75083      +19     
+ Partials     2473     2471       -2
Flag Coverage Δ *Carryforward flag
differential 26.11% <33.33%> (?)
total 24.15% <ø> (-0.01%) ⬇️ Carriedforward from 0cee961

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhisaki yhisaki merged commit eac6332 into autowarefoundation:main Aug 30, 2024
46 of 47 checks passed
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@yhisaki @ktro2828
feat(autoware_motion_utils): add clone function and make the construc…
e7d5e83 
…tor public (autowarefoundation#8688)

* feat(autoware_motion_utils): add interpolator

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* use int32_t instead of int

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* use int32_t instead of int

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* use int32_t instead of int

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const as much as possible and use `at()` in `vector`

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix directory name

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* refactor code and add example

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* update

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* remove unused include

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* refactor code

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add clone function

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix stairstep

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* make constructor to public

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

---------

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@yhisaki yhisaki deleted the update-trajectory_container branch February 5, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soblin soblin soblin approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhisaki @soblin