chore(autoware_gnss_poser): make source codes follow the coding rules #8703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
github-actions
bot
added
component:sensing
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
TaikiYamada4
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
YamatoAndo
as code owners
TaikiYamada4
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8703 +/- ##
==========================================
- Coverage 24.16% 24.10% -0.07%
==========================================
Files 1400 1403 +3
Lines 102242 102471 +229
Branches 38758 38770 +12
==========================================
- Hits 24705 24697 -8
- Misses 75064 75265 +201
- Partials 2473 2509 +36
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TaikiYamada4
deleted the
chore/autoware_gnss_poser/follow_src_naming_rule
branch
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…autowarefoundation#8703) * Follow the coding rules in autoware_gnss_poser Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Edit _core to _node inside files Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> * Fixed AUTOWARE__GNSS_POSER__GNSS_POSER_NODE_HPP_ part Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp> --------- Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the coding rules written in here,
gnss_poser_core.cpp/hppare renamed tognss_poser_node.cpp/hpp.https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#include-and-src
How was this PR tested?
Confirmed that a clean build of
autoware_gnss_poserpackage can been done with no problems.Confirmed that the rosbag replay simulation tutorial worked as usual with this change.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.