refactor(goal_planner): initialize parameter with free function #8712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
requested review from
danielsanchezaran,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
added
the
run:build-and-test-differential
kosuke55
approved these changes
Sep 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8712 +/- ##
==========================================
- Coverage 24.12% 24.11% -0.02%
==========================================
Files 1400 1404 +4
Lines 102281 102341 +60
Branches 38766 38768 +2
==========================================
Hits 24675 24675
- Misses 75035 75095 +60
Partials 2571 2571
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
emuemuJP
pushed a commit
to arayabrain/autoware.universe.origin
that referenced
this pull request
Sep 2, 2024
…warefoundation#8712) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…warefoundation#8712) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
initialize parameters using static function for portability
Related links
Parent Issue:
How was this PR tested?
goal_planner works
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.