Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_static_obstacle_avoidance_module): fix unusedFunction #8732

Conversation

kobayu858
Copy link
Contributor

@kobayu858 kobayu858 commented Sep 3, 2024

Description

This is a fix based on cppcheck unusedFunction warnings.

planning/behavior_path_planner/autoware_behavior_path_static_obstacle_avoidance_module/src/utils.cpp:96:0: style: The function 'findFirstNearestSegmentIndex' is never used. [unusedFunction]
size_t findFirstNearestSegmentIndex(const T & points, const geometry_msgs::msg::Point & point)
^

This function was removed because it is only used in the readme and not used on the actual code.

The readme is a separate package and has been fixed in a #8733

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 3, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) September 3, 2024 06:44
@satoshi-ota satoshi-ota merged commit f189d1b into autowarefoundation:main Sep 3, 2024
36 of 37 checks passed
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.04%. Comparing base (602e3d0) to head (95fee89).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8732   +/-   ##
=======================================
  Coverage   25.04%   25.04%           
=======================================
  Files        1318     1319    +1     
  Lines       97951    97967   +16     
  Branches    37813    37814    +1     
=======================================
+ Hits        24531    24535    +4     
- Misses      70917    70930   +13     
+ Partials     2503     2502    -1     
Flag Coverage Δ *Carryforward flag
differential 20.07% <ø> (?)
total 25.04% <ø> (ø) Carriedforward from 602e3d0

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…sedFunction (autowarefoundation#8732)

fix:unusedFunction

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 deleted the fix/cppcheck_unusedFunction_pla-a1 branch October 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants