Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix object extraction area #8764

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 5, 2024

Description

fix #8714

especially when bound has only two points, polygon can be created correctly

before

image

after

image

Related links

Parent Issue:

psim

2024/09/05 https://evaluation.tier4.jp/evaluation/reports/ea173245-3b3b-5acc-880d-b783123747af/?project_id=prd_jt

fix UC-v3-F-04-00003_005_case01_cmn_general:10

before

image

after

image

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review September 5, 2024 02:57
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.12%. Comparing base (1ae6082) to head (16d04d9).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_path_goal_planner_module/src/util.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8764      +/-   ##
==========================================
- Coverage   24.13%   24.12%   -0.02%     
==========================================
  Files        1407     1411       +4     
  Lines      102317   102374      +57     
  Branches    38830    38832       +2     
==========================================
  Hits        24699    24699              
- Misses      75045    75102      +57     
  Partials     2573     2573              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 24.13% <ø> (+<0.01%) ⬆️ Carriedforward from 1ae6082

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 8213bdf into autowarefoundation:main Sep 5, 2024
46 of 47 checks passed
@kosuke55 kosuke55 deleted the fix/object_extraction_area branch September 5, 2024 09:00
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Sep 6, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
emuemuJP pushed a commit to arayabrain/autoware.universe.origin that referenced this pull request Sep 10, 2024
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: emuemuJP <k.matsumoto.0807@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants