Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance, avoidance_by_lane_change): remove unused variable #8926

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Sep 20, 2024

Description

Removes unused variables in static_obstacle_avoidance module and avoidance_by_lane_change moduel.

Related links

autowarefoundation/autoware_launch#1176

How was this PR tested?

Notes for reviewers

None.

Interface changes

ROS Parameter Changes

Additions and removals

Change type Parameter Name
Removed car.execute_num
Removed truck.execute_num
Removed bus.execute_num
Removed trailer.execute_num
Removed unknown.execute_num
Removed bicycle.execute_num
Removed motorcycle.execute_num
Removed pedestrian.execute_num

Effects on system behavior

None.

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 20, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.96%. Comparing base (be9a404) to head (e4fb03b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8926      +/-   ##
==========================================
- Coverage   27.96%   27.96%   -0.01%     
==========================================
  Files        1319     1320       +1     
  Lines       98745    98760      +15     
  Branches    39808    39807       -1     
==========================================
+ Hits        27614    27616       +2     
- Misses      71037    71050      +13     
  Partials       94       94              
Flag Coverage Δ *Carryforward flag
differential 20.96% <ø> (?)
total 27.96% <ø> (-0.01%) ⬇️ Carriedforward from be9a404

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori merged commit c70daa0 into autowarefoundation:main Sep 20, 2024
45 of 46 checks passed
@go-sakayori go-sakayori deleted the fix/remove_unused branch September 20, 2024 08:15
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 20, 2024
…ed variable (autowarefoundation#8926)

remove unused variables

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants